Bug 473627

Summary: bacula : Unowned directories
Product: [Fedora] Fedora Reporter: Michael Schwendt <bugs.michael>
Component: baculaAssignee: Andreas Thienemann <andreas>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: andreas, limburgher, mmcgrath
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-12-01 14:51:16 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Attachments:
Description Flags
Current bacula.spec none

Description Michael Schwendt 2008-11-29 13:36:19 EST
One or more directories are not included within this
package and/or its sub-packages:

=> bacula-common-2.4.3-3.fc11.i386 (rawhide-development-i386)
/etc/logrotate.d

=> bacula-console-2.4.3-3.fc11.i386 (rawhide-development-i386)
/etc/bacula

=> bacula-console-bat-2.4.3-3.fc11.i386 (rawhide-development-i386)
/etc/bacula

=> bacula-console-gnome-2.4.3-3.fc11.i386 (rawhide-development-i386)
/etc/bacula

=> bacula-console-wxwidgets-2.4.3-3.fc11.i386 (rawhide-development-i386)
/etc/bacula

[
=> bacula-director-common-2.4.3-3.fc11.i386 (rawhide-development-i386)
/etc/logwatch
/etc/logwatch/scripts
/etc/logwatch/scripts/services
/etc/logwatch/conf
/etc/logwatch/conf/logfiles
/etc/logwatch/conf/services
]

=> bacula-traymonitor-2.4.3-3.fc11.i386 (rawhide-development-i386)
/etc/bacula

[...]

Further information:

https://fedoraproject.org/wiki/Packaging/ReviewGuidelines

MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which
does create that directory.

https://fedoraproject.org/wiki/Packaging/Guidelines#FileAndDirectoryOwnership
https://fedoraproject.org/wiki/Packaging/UnownedDirectories
Comment 1 Andreas Thienemann 2008-11-29 14:20:39 EST
Michael,

your script is broken AFAICS.

/etc/bacula is owned by the -common package. This should be required by the bacula subpackages.

About the other stuff however, you might be right. I'd have to check.
Comment 2 Michael Schwendt 2008-11-29 14:46:53 EST
> /etc/bacula is owned by the -common package.
> This should be required by the bacula subpackages.

The sub-packages do not require the -common package.
Comment 3 Gwyn Ciesla 2008-12-01 14:15:04 EST
(In reply to comment #2)
> > /etc/bacula is owned by the -common package.
> > This should be required by the bacula subpackages.
> 
> The sub-packages do not require the -common package.

Yes, they do.

The logwatch bits in /etc are owned by logwatch, except for /etc/logwatch/conf/logfiles/bacula.conf and /etc/logwatch/conf/services/bacula.conf, owned by bacula-director-common.

I see no problem here.  Andreas, do you concur?
Comment 4 Michael Schwendt 2008-12-01 14:29:38 EST
> Yes, they do.

No, they don't.

Any now what? How about you give proof?

FWIW, I trust the automatic depsolving that is done here.
Comment 5 Gwyn Ciesla 2008-12-01 14:38:09 EST
(In reply to comment #4)
> > Yes, they do.
> 
> No, they don't.
> 
> Any now what? How about you give proof?

[limb@fawkes services]$ rpm -q --whatrequires bacula-common
bacula-client-2.4.3-3.fc9.i386
bacula-storage-common-2.4.3-3.fc9.i386
bacula-director-sqlite-2.4.3-3.fc9.i386
bacula-director-common-2.4.3-3.fc9.i386
bacula-storage-sqlite-2.4.3-3.fc9.i386


Attaching spec file.

> FWIW, I trust the automatic depsolving that is done here.
Comment 6 Gwyn Ciesla 2008-12-01 14:39:04 EST
Created attachment 325282 [details]
Current bacula.spec
Comment 7 Andreas Thienemann 2008-12-01 14:51:16 EST
I took a closer look and unfortunately, Michael is right.

The console subpackages do not own the /etc/bacula dir. The bacula-common
subpackage does.

Easyfix would be to require the -common subpackage by the -client utilities as
well. I'd hate to see this done however as it pulls in much more then
necessary.

The other solution, having several packages provide the same dir is not really
appealing either.

The third idea of further splitting up the bacula packages just for one dir is
stupid as well.

*shrug* However, as I don't really care we now have a further subpackage owning
exactly one directory...

Regarding the logwatch bits, added the necessary dependency...

I'm not triggering a build for this however. It's in CVS and will be included in the next build.