Bug 473679

Summary:	Review Request: xfburn - Simple CD/DVD burning tool based on libburnia
Product:	[Fedora] Fedora	Reporter:	Christoph Wickert <christoph.wickert>
Component:	Package Review	Assignee:	Michael Schwendt <bugs.michael>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bugs.michael, denis, fedora-package-review, kevin, notting, pahan, sundaram
Target Milestone:	---	Flags:	bugs.michael: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-12-04 03:31:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Christoph Wickert 2008-11-30 00:02:05 UTC

Spec URL: http://cwickert.fedorapeople.org/review/xfburn.spec
SRPM URL: http://cwickert.fedorapeople.org/review/xfburn-0.3.91-1.fc11.src.rpm
Description: Xfburn is a simple CD/DVD burning tool based on libburnia libraries. It can 
blank CD-RWs, burn and create iso images, as well as burn personal 
compositions of data to either CD or DVD.

Comment 1 Michael Schwendt 2008-12-03 18:58:35 UTC

Fine package. Burnt a CD-RW as a test without any problems. In GNOME.

Only adjustments I could think of:
 * Requiring "hicolor-icon-theme" for the icon hierarchy.
 * Removing the Xfce reference in the summary.
 * Be careful with the --enable-debug option as not to enable anything you may not like. Currently it's okay, though.

APPROVED

Comment 2 Christoph Wickert 2008-12-03 20:24:50 UTC

Thanks for the review.

(In reply to comment #1)
> Fine package. Burnt a CD-RW as a test without any problems. In GNOME.
> 
> Only adjustments I could think of:
>  * Requiring "hicolor-icon-theme" for the icon hierarchy.

Xfburn already requires hicolor-icon theme trough gtk2, but I can add it explicitly.

>  * Removing the Xfce reference in the summary.
>  * Be careful with the --enable-debug option as not to enable anything you may
> not like. Currently it's okay, though.

This is actually a relict of debuging a reproducable crash in 3.2. Good catch.

> APPROVED


@Denis: I'd like you to be able to do a rebuild of this package when necessary (soname bump of libburn or libisofs), so I add you as owner.

New Package CVS Request
=======================
Package Name: xfburn
Short Description: Simple CD/DVD burning tool based on libburnia
Owners: cwickert denis
Branches: F-9 F-10
InitialCC:

Comment 3 Kevin Fenzi 2008-12-04 00:40:05 UTC

cvs done.

Comment 4 Christoph Wickert 2008-12-04 03:31:44 UTC

I have decided not to push this for F10, because the program is still to crashy for the stable release. F-9 does not even meet the buildrequires, so only Rawhide build is available.

Closing.

Comment 5 Denis Leroy 2008-12-05 20:50:09 UTC

> @Denis: I'd like you to be able to do a rebuild of this package when necessary
> (soname bump of libburn or libisofs), so I add you as owner.

Christoph, good idea. Thank you.

Comment 6 Fedora Update System 2009-03-22 23:29:41 UTC

xfburn-0.4.1-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/xfburn-0.4.1-1.fc10

Comment 7 Fedora Update System 2009-03-23 15:48:55 UTC

xfburn-0.4.1-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.