Bug 473775
| Summary: | Review Request: gpshell - Manage applets on GlobalPlatform and OpenPlatform smart cards | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | François Kooman <fkooman> | ||||||
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> | ||||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | dcantrell, fedora-package-review, herrold, mtasaka, notting | ||||||
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2008-12-10 15:05:25 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 463266 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
François Kooman
2008-11-30 14:19:05 UTC
Created attachment 325126 [details]
SUN license for included HelloWorld.cap file
There is problem with this package with regard to the included HelloWorld.cap file from Sun's JavaCard SDK. The attachment shows the license text you need to agree to when downloading the SDK (http://java.sun.com/javacard/devkit/). I guess this needs to be removed (https://fedoraproject.org/wiki/Packaging/SourceURL#When_Upstream_uses_Prohibited_Code) but I wanted to have some feedback on this before doing this... Driveby comment, the summary is a bit wrong. You shouldn't repeat the name of the package in the summary. "Script interpreter which talks to smart cards" or even "Smart Card script interpreter" Fixed summary: Spec URL: http://users.tuxed.net/fkooman/rpmbuild/SPECS/gpshell.spec SRPM URL: http://users.tuxed.net/fkooman/rpmbuild/SRPMS/gpshell-1.4.2-3.fc10.src.rpm Created attachment 325271 [details] mock build log About HelloWorld.cap - This file seems to be a zip file, containing some binaries (named *.cap), not a image file or so and currently I don't know how to create this file itself. Is this file needed to build gpshell or to use gpshell? - If not, please simply remove this files (and so on) and repackage tarball: https://fedoraproject.org/wiki/Packaging/SourceURL#When_Upstream_uses_Prohibited_Code I think this Sun license is non-free. - If this file (and so on) is needed, anyway Fedora has a policy that all binaries (except for some cases) must be built from sources, so this file itself must be built from FOSS sources. By the way rebuilt itself fails (build log attached) Spec URL: http://users.tuxed.net/fkooman/rpmbuild/SPECS/gpshell.spec SRPM URL: http://users.tuxed.net/fkooman/rpmbuild/SRPMS/gpshell-1.4.2-4.fc10.src.rpm - fix mock build by including zlib-devel in BuildReq - regenerate tarball without Sun sample code and use that No binaries in the tarball left (except for the windows .ico file). For -4:
* Timestamp
- For this package "CPPROG='cp -p'" is not useful (so this
can simply be removed) because this package does not use
install-sh
(anyway keeping timestamps is not useful because all files
to be installed (except for %doc files) are created
at %build stage)
Other things is okay.
-----------------------------------------------------------
This package (gpshell) is APPROVED by mtasaka
-----------------------------------------------------------
Spec URL: http://users.tuxed.net/fkooman/rpmbuild/SPECS/gpshell.spec SRPM URL: http://users.tuxed.net/fkooman/rpmbuild/SRPMS/gpshell-1.4.2-5.fc10.src.rpm - remove keep timestamps on make install as install-sh is not used anyway Thanks for your time! :) New Package CVS Request ======================= Package Name: gpshell Short Description: Manage applets on GlobalPlatform and OpenPlatform smart cards Owners: fkooman Branches: F-9 F-10 InitialCC: cvs done. Closing. |