Bug 473944

Summary: Change TopDir in config file does not affect pool and cpool
Product: [Fedora] Fedora Reporter: Filipe Brandenburger <filbranden>
Component: BackupPCAssignee: Johan Cwiklinski <johan>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: johan
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 3.1.0-4.fc9 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-05-20 00:48:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Patch for lib/BackupPC/Lib.pm none

Description Filipe Brandenburger 2008-12-01 15:17:20 UTC
Created attachment 325239 [details]
Patch for lib/BackupPC/Lib.pm

Description of problem:
Changing TopDir in config file does not affect pool and cpool, BackupPC still thinks those are under the default directory /var/lib/BackupPC


Version-Release number of selected component (if applicable):
3.1.0-3.fc10


How reproducible:
Every time.


Steps to Reproduce:
1. Set $Conf{TopDir} = '/whatever'; in config.pl
2. Create /whatever with the default BackupPC directories (pool, cpool, pc, trash) and right permissions.
3. Run a backup.
  

Actual results:
cpool will be empty, and this will be the output in /var/log/BackupPC/LOG:
2008-11-29 10:23:40 BackupPC_link got error -4 when calling MakeFileLink(/whatever/pc/xxxname/0/f%2fetc/fDIR_COLORS, a1fbdaecae5425dc9d24653e5c87a22e, 1)



Expected results:
The files in cpool would be correctly created.


Additional info:
This mailing list post has a patch for the problem:
http://sourceforge.net/mailarchive/message.php?msg_name=20080808032558.GG13869%40gratch.parplies.de

I'm attaching the same patch here.

I applied this patch to an already installed BackupPC from the Fedora RPM, and after that it worked as supposed to.

Comment 1 Johan Cwiklinski 2008-12-07 12:03:33 UTC
I understand the problem...

But these patch is not included upstream, and seems not well tested...

I'll keep this in mind, but won't include it for now, I'd like to have more come backs before.

Comment 2 Filipe Brandenburger 2008-12-07 15:52:53 UTC
The same problem has been reported several other times in the backuppc-devel list:
http://sourceforge.net/mailarchive/forum.php?thread_name=48CEEE9A.3080106%40resheteva.lan&forum_name=backuppc-devel
http://sourceforge.net/mailarchive/forum.php?thread_name=20080917151648.GC22362%40localhost.localdomain&forum_name=backuppc-devel
http://sourceforge.net/mailarchive/forum.php?thread_name=491B3BD2.4080301%40gmail.com&forum_name=backuppc-devel
http://sourceforge.net/mailarchive/forum.php?thread_name=4921C17B.1050905%40resheteva.lan&forum_name=backuppc-devel

The problem has been reported to the list since August, but so far the developers have not said anything about it. If you have another way of contacting them, please do, since this is a problem that should be simple to solve.

There is an alternative patch suggested by a Debian user, but it's setting the variables on the wrong place, inside the function that reads the config file instead of after calling that function where TopDir may potentially be changed.

If you look at the patch, it's extremely straighforward, all it's doing is setting CPool and Pool *after* resetting TopDir instead of before. You can also do the steps on the reported bug and verify that it indeed happens, and cpool will be empty. In fact, you will have a directory structure created under /var/lib/backuppc, no matter what you set TopDir to.

There is also the Debian bug:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=495504

But there they took a ridiculous approach of saying that if you want to do that, you should use a symbolic link in /var/lib/backuppc to wherever you want to move it, but that is ridiculous since it breaks the installed RPM (rpm --verify will point that out), and also, if that's the case, the possibility to redefine TopDir should be removed from the config.

I still think you should go ahead and apply the patch.

Comment 3 Johan Cwiklinski 2008-12-07 18:08:53 UTC
The symlink is what I've used for long times, it was not possible to change the backup dir in BackupPC 2.x ; and I've kept this method.

But I'm okay, I'll take a look to push the new patched version on testing this week ; the patch is very simple, thanks for it.

Comment 4 Filipe Brandenburger 2008-12-10 22:39:32 UTC
Hi,

Please see this message by Paul Mantz from the backuppc-devel mailing list:
http://sourceforge.net/mailarchive/forum.php?thread_name=42f28fe0812101410v5d625b3g68693c28e1a8b258%40mail.gmail.com&forum_name=backuppc-devel

It includes a patch for the issue (similar to the one I posted, however putting the lines a little lower in the code).

Also have a look at this previous e-mail, where Craig Barratt says Paul Mantz is actually who has been doing more development in BackupPC recently:
http://sourceforge.net/mailarchive/forum.php?thread_name=a1a3029e-c4b5-4788-b381-560a8373e5fb&forum_name=backuppc-devel

He says this patch will be included in the next Zmanda release of BackupPC, and as the other e-mail suggests, it will be also present in the next main release of BackupPC as well.

Comment 5 Johan Cwiklinski 2008-12-24 04:51:39 UTC
Paul Mantz released a "BackupPC Community 3.1.1" : http://sourceforge.net/mailarchive/forum.php?thread_name=42f28fe0812221729y3915cdcei1900877208cfbd54%40mail.gmail.com&forum_name=backuppc-users

But, for the moment, changes were not commited upstream, so I won't package this version, I'll wait for changes to be commited upstream, as he promised.

This work on BackupPC seems a little bit closed to me, and zmanda's backuppc.com does not seem to be affiliated in any way with the project.

Patching should also be a solution, but I'd prefer to see an official new release :)

Comment 6 Fedora Update System 2009-04-10 16:22:01 UTC
BackupPC-3.1.0-4.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/BackupPC-3.1.0-4.fc10

Comment 7 Fedora Update System 2009-04-10 16:22:06 UTC
BackupPC-3.1.0-4.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/BackupPC-3.1.0-4.fc9

Comment 8 Fedora Update System 2009-04-13 19:33:49 UTC
BackupPC-3.1.0-4.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update BackupPC'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-3517

Comment 9 Fedora Update System 2009-04-13 19:45:17 UTC
BackupPC-3.1.0-4.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing-newkey update BackupPC'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-3608

Comment 10 Fedora Update System 2009-05-20 00:48:46 UTC
BackupPC-3.1.0-4.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2009-05-20 00:53:43 UTC
BackupPC-3.1.0-4.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.