Bug 474141
| Summary: | Variable names with underscores are highlighted incorrectly patch included | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mat Booth <mat.booth> | ||||
| Component: | eclipse-shelled | Assignee: | Alexander Kurtakov <akurtako> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 10 | CC: | akurtako, john.brown009 | ||||
| Target Milestone: | --- | Keywords: | Patch | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-02-05 02:16:05 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Created attachment 325371 [details]
Fix syntax highlighting of variable names with underscores
(In reply to comment #0) > Hi Alexander, > > Would you consider adding this patch to ShellEd? > > An example of the problem it fixes: > > TEST_VAR=xyz # Colored properly > ONE=$TEST_VAR # "_VAR" is not colored > TWO=${TEST_VAR} # "${TEST_VAR}" is not colored > > I have submitted this patch upstream also[1], but they seem to be very > unresponsive. :-( > > [1] > http://sourceforge.net/tracker/index.php?func=detail&aid=2149875&group_id=116855&atid=676238 Hi Mat, I'll add your patch in the upstream repository :). Sorry for being unresponsive (alhough i'm one of the devs from 2 weeks). And I plan to push new upstream release with other cleanups and this fix is going to be part of it for sure. Hopefully the plugin will be revived so if you have any other fixes push them upstream. I'll try to be as responsive as my time permits. Heh, I didn't realise that you actually *are* the upstream... Thanks for the quick response. This bug has been triaged eclipse-shelled-1.0.4-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/eclipse-shelled-1.0.4-1.fc10 eclipse-shelled-1.0.4-1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update eclipse-shelled'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0361 eclipse-shelled-1.0.4-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |
Hi Alexander, Would you consider adding this patch to ShellEd? An example of the problem it fixes: TEST_VAR=xyz # Colored properly ONE=$TEST_VAR # "_VAR" is not colored TWO=${TEST_VAR} # "${TEST_VAR}" is not colored I have submitted this patch upstream also[1], but they seem to be very unresponsive. :-( [1] http://sourceforge.net/tracker/index.php?func=detail&aid=2149875&group_id=116855&atid=676238