Bug 474160

Description of problem:
When using pam_abl in conjuction with openssh, a user can try to authenticate several times in the same ssh connection. Failing to login will only be counted as 1 failed authentication attempt instead of the 6 (default) failed attempts.

Version-Release number of selected component (if applicable):
pam_abl 0.2.3-6.fc10
openssh-server 5.1p1-3.fc10

How reproducible:
Always

Steps to Reproduce:
1. install pam_abl and openssh-server and set up pam_abl
2. initiate an ssh connection (I'm using putty)
3. try to authenticate as a user with a wrong password
4. loop step 3 until the connection is closed because of too many failed attempts  (by default should be 6)

  
Actual results:
* look at the pam_abl database status: only 1 failed attempt is recorded

Expected results:
* 6 failed attempts should have been recorded to pam_abl DB.

Additional info:
* this bug was related to a bug in openssh which has been fixed in 4.7p3 I think (at least it is fixed in 4.8)

* the other part of the bug is due to a missing fix in pam_abl
"also record attempts on consecutive auth tries" see (http://pam-abl.svn.sourceforge.net/viewvc/pam-abl?view=rev&revision=13)

* The fix applies cleanly on the pam_ldap.c file after all fixes included in current SRPM.

I can report that after applying the fix, pam_abl works as expected:

--------
--- pam_abl.c	2007/10/03 10:42:16	12
+++ pam_abl.c	2007/10/03 21:14:48	13
@@ -356,10 +356,15 @@
 
 PAM_EXTERN int pam_sm_authenticate(pam_handle_t *pamh, int flags, int argc, const char **argv) {
     abl_args *args;
-    int err = PAM_SUCCESS;
+    const void *prev_args;
+    int err;
 
     /*log_debug(NULL, "pam_sm_authenticate(), flags=%08x", flags);*/
 
+    if (pam_get_data(pamh, DATA_NAME, &prev_args) == PAM_SUCCESS) {
+        record_attempt(prev_args);
+    }
+
     if (args = malloc(sizeof(abl_args)), NULL == args) {
         return PAM_BUF_ERR;
     }
--------

Regards,
Thibault