Bug 474163
| Summary: | gfs_controld: receive_own from N messages with plock_ownership enabled | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Nate Straz <nstraz> |
| Component: | cman | Assignee: | David Teigland <teigland> |
| Status: | CLOSED ERRATA | QA Contact: | Cluster QE <mspqa-list> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 5.3 | CC: | cfeist, cluster-maint, cmarthal, edamato, everett.bennett, john.e.anderson, rlerch |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | cman-2.0.100-1.el5 | Doc Type: | Bug Fix |
| Doc Text: |
- cause: enable plock_ownership for gfs_controld
- consequence: nodes mounting gfs have inconsistent views of posix locks on the fs
- fix: reverse inverted mode of synced locks, and sync resources with no locks so that the resource owner is synced
- result: posix locks remain consistent among nodes when plock_ownership is enabled
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-09-02 11:10:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nate Straz
2008-12-02 15:49:41 UTC
Here's a fix to at least one problem that can lead to all sorts of chaos;
there may be others.
commit 4cae2bce5468278206bbac2b46bb7e18a2693c43
Author: David Teigland <teigland>
Date: Wed Dec 3 17:07:34 2008 -0600
gfs_controld: fix lock syncing in ownership mode
bz 474163
Locks that are synced due to a resource being "un-owned"
were having their read/write mode reversed on the nodes
being synced to. This causes the plock state on the nodes
to become out of sync, and operate wrongly.
Signed-off-by: David Teigland <teigland>
diff --git a/group/gfs_controld/plock.c b/group/gfs_controld/plock.c
index 1b9bbe2..aa59ea3 100644
--- a/group/gfs_controld/plock.c
+++ b/group/gfs_controld/plock.c
@@ -1401,7 +1401,7 @@ static void _receive_sync(struct mountgroup *mg, char *bu
}
if (hd->type == MSG_PLOCK_SYNC_LOCK)
- add_lock(r, info.nodeid, info.owner, info.pid, !info.ex,
+ add_lock(r, info.nodeid, info.owner, info.pid, info.ex,
info.start, info.end);
else if (hd->type == MSG_PLOCK_SYNC_WAITER)
add_waiter(mg, r, &info);
Using the fix in comment 1, I've not been able to reproduce any of the errors I saw before, or that Nate saw before. Fix pushed to git branches: STABLE2 gfs_controld RHEL5 gfs_controld master gfs_controld and dlm_controld Found another major bug with ownership code: new nodes mounting and syncing plock state from existing nodes were ignoring resources without locks. This means the new nodes would have no record of resources owned by other nodes. I'll fix this as a part of this bz as well. Fix for comment 3 pushed to git branches. gfs_controld: read lockless resources from ckpts STABLE2 gfs_controld d09d455d3bf5fa93eed53506856c47b30d27f775 RHEL5 gfs_controld 3d06a50da2541c94027392e39863fa61ac5f0214 master gfs_controld and dlm_controld d8b4d87c8fd9502aea03f1782a3178b2828ef0d2 gfs2-utils-2.03.11-1.fc9, cman-2.03.11-1.fc9, rgmanager-2.03.11-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. Release note added. If any revisions are required, please set the "requires_release_notes" flag to "?" and edit the "Release Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: - cause: enable plock_ownership for gfs_controld - consequence: nodes mounting gfs have inconsistent views of posix locks on the fs - fix: reverse inverted mode of synced locks, and sync resources with no locks so that the resource owner is synced - result: posix locks remain consistent among nodes when plock_ownership is enabled *** Bug 512799 has been marked as a duplicate of this bug. *** An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2009-1341.html |