Bug 474193
| Summary: | Review Request: glog - A C++ application logging library | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | John A. Khvatov <ivaxer> | ||||
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | a.badger, fedora-package-review, ivaxer, ivaxer, mtasaka, notting, panemade | ||||
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | glog-0.3.3-8.el7 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-12-15 15:48:55 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
John A. Khvatov
2008-12-02 18:14:09 UTC
you need to use autotools because you have modified configure. I tried but end up with many errors from libtool. when asked same on #fedora-devel I got link http://bugs.gentoo.org/236758 and bug 474330 (In reply to comment #1) > you need to use autotools because you have modified configure. Why not use pregenerated configure? It's works fine for me. So, i fix spec file to using autoconf: SPEC: http://dev.sgu.ru/~ivaxer/glog.spec SRPM: http://dev.sgu.ru/~ivaxer/glog-0.1.2-5.fc10.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=973485 - fix %%{_includedir}
- fixed documentation
SPEC: http://dev.sgu.ru/~ivaxer/glog.spec
SRPM: http://dev.sgu.ru/~ivaxer/glog-0.1.2-6.fc10.src.rpm
Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=986777 + rpmlint is silent for SRPM and RPMs + source files match upstream url 64b44e0a36b25c4afc77a0f6b2b208ed glog-0.1.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package glog-0.1.2-6.fc11 => Provides: libglog.so.0 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libc.so.6(GLIBC_2.7) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgcc_s.so.1(GLIBC_2.0) libglog.so.0 libm.so.6 libpthread.so.0 libpthread.so.0(GLIBC_2.0) libpthread.so.0(GLIBC_2.1) libpthread.so.0(GLIBC_2.2) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) libstdc++.so.6(GLIBCXX_3.4.9) rtld(GNU_HASH) + Package glog-devel-0.1.2-6.fc11 => Requires: libglog.so.0 + Not a GUI application. Note that I saw some messages in build.log like aclocal-1.10: command not found automake-1.10: command not found But still build is successful so if anyone sees this as blocker please comment here or report bug once this gets into Fedora. APPROVED. New Package CVS Request ======================= Package Name: glog Short Description: A C++ application logging library Owners: ivaxer Branches: F-10 InitialCC: To mtasaka: fedora-cvs flag is needed. Created attachment 326603 [details]
fedora-cvs flag is here
Do you still have a trouble in setting fedora-cvs flag?
If so, would you ask Toshio Kuratomi <a.badger>
with telling him your FAS name (ivaxer)?
By the way, the place to set fedora-cvs flag on this bug is attached.
Are you trying to set the flag while logged in as ivaxer fedoraproject.org? That won't work because the ivaxer address doesn't have the extra bugzilla permissions to set it. The email address you have registered in FAS (ivaxer stingr net) will work. (In reply to comment #8) > Are you trying to set the flag while logged in as ivaxer fedoraproject.org? Yes. > That won't work because the ivaxer address doesn't have the extra bugzilla > permissions to set it. The email address you have registered in FAS (ivaxer > stingr net) will work. Thanks. (Previously, I changed email to fp.o via bugzilla web interface and started to use ivaxer fp.o login) Thank you, Toshio. cvs done. glog-0.1.2-6.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/glog-0.1.2-6.fc10 glog-0.1.2-6.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: glog New Branches: epel7 Owners: ivaxer Git done (by process-git-requests). glog-0.3.3-8.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/glog-0.3.3-8.el7 glog-0.3.3-8.el7 has been pushed to the Fedora EPEL 7 stable repository. |