Bug 474430
Summary: | Review Request: python-uulib - Python interface to RFC 4122 compliant UUID objects | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ray Van Dolson <rayvd> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, rvandolson |
Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-02-16 23:44:36 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ray Van Dolson
2008-12-03 19:42:06 UTC
This is intended solely for EPEL 4 and 5 as the uuid module is included in Fedora already. It's tough to review this as I don't even have the means to build it properly. I only know how to build Fedora packages, and I guess it should come as no surprise that it doesn't even build in rawhide as python isn't in the buildroot. Any way you could provide a built package and perhaps the build log? Or I guess you could wait for someone who knows how to build EPEL-only packages to review this. Hmm... sure. I can do that in mock. Hopefully I didn't miss a procedure for EPEL only packages (didn't see one). Thanks! FYI, here are the mock results for both EPEL-4 and EPEL-5: http://rayvd.fedorapeople.org/python-uuid/mock-el4/ http://rayvd.fedorapeople.org/python-uuid/mock-el5/ I'll check on epel-list to see how EPEL only packages have been handled in the past as well. Basically, every package must have a devel branch; you should immediately dead.package it upon import to ensure that the package is never branched for any Fedora releases. I don't know of any EPEL-specific procedure other than that. I'll note for posterity that the code carries no license, but the README.txt file which comes from the same upstream site specifies one. rpmlint says: python-uuid.i386: E: no-binary python-uuid-debuginfo.i386: E: empty-debuginfo-package The debuginfo package is empty, and I see no calls to the compiler in the build log. Are you sure this package needs to be arch-specific? I'm not sure it would even build properly on x86_64; did you try? (On that platform, python_sitearch and python_sitelib aren't the same, while on i386 they are.) * source files match upstream. sha256sum: 1f87cc004ac5120466f36c5beae48b4c48cc411968eed0eaecd3da82aa96193f uuid-1.30.tar.gz 2b50f69a57f89054027ff1ab495aca9b65664edb6e76d1b6e4064584cfac948f uuid.README.txt * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * BuildRequires are proper. * %clean is present. * package builds in mock (EPEL5, i386). X debuginfo package is empty. X rpmlint has valid complaints. final provides and requires are sane: python-uuid = 1.30-1.el5 = python >= 2.3 python(abi) = 2.4 * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. Any response? It's been over a month now. Apologies on the delay. Vacation and resulting fallout but I'll get on this again today. Updated spec and SRPM: http://rayvd.fedorapeople.org/python-uuid/python-uuid.spec http://rayvd.fedorapeople.org/python-uuid/python-uuid-1.30-2.el5.src.rpm Switched to noarch. Unfortunately your comment came after the start of the semester, so I've been a bit busy. Fortunately I have more time now, so I can finish this up. Things look good now that this is noarch. The only remaining issue I see is that you have Requires: python >= 2.3, python < 2.5 However, rpm will automaticaly insert a dependency on python(abi) = 2.4 Currently there's no guideline against this, but you might want to check out the following draft, which is working its way through the system: http://fedoraproject.org/wiki/PackagingDrafts/ExplicitRequires So I'll go ahead and approve this, but I would recommend that you kill that extra Requires: line. APPROVED Thanks Jason! RPM adds this implicit requires based on the BuildRequires I'm assuming? Makes sense and I'll remove the explicit Requires from the final version of the package. Thanks for your work on this. For posterity's sake, here are the final spec and SRPM: http://rayvd.fedorapeople.org/python-uuid/python-uuid.spec http://rayvd.fedorapeople.org/python-uuid/python-uuid-1.30-3.el5.src.rpm New Package CVS Request ======================= Package Name: python-uuid Short Description: Python interface to RFC 4122 compliant UUID objects Owners: rayvd Branches: EL-5 InitialCC: New Package CVS Request ======================= Package Name: python-uuid Short Description: Python interface to RFC 4122 compliant UUID objects Owners: rayvd Branches: EL-4 EL-5 InitialCC: cvs done. |