Bug 474812
Summary: | Review Request: perl-Class-Unload - unload given Class | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Marcela Mašláňová <mmaslano> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, iarnell, notting |
Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-12-10 07:20:56 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Marcela Mašláňová
2008-12-05 13:49:08 UTC
rpmlint says: perl-Class-Unload.noarch: W: summary-not-capitalized unload given Class Easy to fix. perl-Class-Unload.noarch: E: description-line-too-long Unloads the given class by clearing out its symbol table and removing it from %INC. Just needs one carriage return. Those are really trivial, so I'll go ahead and approve this and you can fix them when you check in. * source files match upstream. sha256sum: 01807226cd9a6b5b1c6a02cf8408ab09e0e76e7d70f06f6d3fe3af6e41906005 Class-Unload-0.05.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK (needs capitalization). * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(Class::Unload) = 0.05 perl-Class-Unload = 0.05-1.fc11 = perl >= 0:5.005 perl(:MODULE_COMPAT_5.10.0) perl(Class::Inspector) perl(strict) perl(vars) perl(warnings) * %check is present and all tests pass: All tests successful. Files=5, Tests=21, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.09 cusr 0.02 csys = 0.13 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED, just fix up Summary: and %description. Summary and description will be fixed. New Package CVS Request ======================= Package Name: perl-Class-Unload Short Description: unload given Class Owners: mmaslano Branches: F-10 devel InitialCC: fedora-perl-devel-list cvs done. Package Change Request ====================== Package Name: perl-Class-Unload New Branches: el6 Owners: iarnell mmaslano Marcela's agreement in #629628 Git done (by process-git-requests). |