Bug 474818

Summary: Review Request: perl-Class-XSAccessor - Generate fast XS accessors without runtime compilation
Product: [Fedora] Fedora Reporter: Marcela Mašláňová <mmaslano>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, i, notting, panemade, ppisar, psabata
Target Milestone: ---Flags: panemade: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-12-16 08:08:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 474815    
Bug Blocks: 1108381    

Description Marcela Mašláňová 2008-12-05 14:24:51 UTC
Spec URL: http://mmaslano.fedorapeople.org/perl-Class-XSAccessor/perl-Class-XSAccessor.spec
SRPM URL: http://mmaslano.fedorapeople.org/perl-Class-XSAccessor/perl-Class-XSAccessor-0.11-1.fc10.src.rpm
Description: Class::XSAccessor implements fast read, write and read/write accessors in XS. Additionally, it can provide predicates such as has_foo() for testing whether the attribute foo is defined in the object. It only works with
objects that are implemented as ordinary hashes. Class::XSAccessor::Array
implements the same interface for objects that use arrays for their
internal representation.

Comment 1 Jason Tibbitts 2008-12-10 20:20:17 UTC
AutoXS::Header does not seem to be available in rawhide yet.

Comment 2 Parag AN(पराग) 2008-12-13 10:56:46 UTC
build failed because of missing BR perl(Test::More)
Can't locate Test/More.pm

See http://koji.fedoraproject.org/koji/taskinfo?taskID=996515

Comment 4 Parag AN(पराग) 2008-12-15 09:18:25 UTC
Just saw that upstream source is now downloadable and new sources are already in releases.
Can you resubmit this SRPM with new source
http://www.cpan.org/authors/id/S/SM/SMUELLER/Class-XSAccessor-0.14.tar.gz ?

Comment 5 Parag AN(पराग) 2008-12-15 09:18:53 UTC
oops s/now/not

Comment 7 Marcela Mašláňová 2008-12-15 11:25:03 UTC
http://koji.fedoraproject.org/koji/taskinfo?taskID=999048

Comment 8 Parag AN(पराग) 2008-12-15 13:15:03 UTC
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=999048
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
6cc5e214d9873f9205c2c49a1b7f3008  Class-XSAccessor-0.14.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
All tests successful.
Files=6, Tests=65,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.19 cusr  0.02 csys =  0.23 CPU)
+ Package perl-Class-XSAccessor-0.14-1.fc11 =>
  Provides: XSAccessor.so perl(Class::XSAccessor) = 0.14
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) perl >= 0:5.006 perl(Carp) perl(XSLoader) perl(strict) perl(warnings) rtld(GNU_HASH)

APPROVED.

Comment 9 Marcela Mašláňová 2008-12-15 13:24:27 UTC
New Package CVS Request
=======================
Package Name: perl-Class-XSAccessor
Short Description: Generate fast XS accessors without runtime compilation
Owners: mmaslano
Branches: F-10
InitialCC: perl-sig

Comment 10 Dennis Gilmore 2008-12-15 20:42:13 UTC
CVS Done

Comment 11 Petr Pisar 2014-06-20 06:42:12 UTC
*** Bug 1111446 has been marked as a duplicate of this bug. ***

Comment 12 Petr Pisar 2014-06-20 06:45:11 UTC
Package Change Request
======================
Package Name: perl-Class-XSAccessor
New Branches: epel7
Owners: cicku
InitialCC: perl-sig

As requested in bug #1111446.

Comment 13 Kevin Fenzi 2014-06-21 17:13:09 UTC
Git done (by process-git-requests).

Comment 14 Petr Šabata 2014-10-09 13:14:55 UTC
Package Change Request
======================
Package Name: perl-Class-XSAccessor
New Branches: el6
Owners: psabata
InitialCC: perl-sig

I'd like to get this into EPEL6 for #1132356.

Comment 15 Kevin Fenzi 2014-10-13 23:01:27 UTC
Git done (by process-git-requests).

Comment 16 Petr Šabata 2014-10-14 09:01:17 UTC
Thanks, Kevin.

Comment 17 Fedora Update System 2014-10-14 09:15:30 UTC
perl-Class-XSAccessor-1.19-4.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Class-XSAccessor-1.19-4.el6

Comment 18 Fedora Update System 2014-10-24 15:07:26 UTC
perl-Class-XSAccessor-1.19-5.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Class-XSAccessor-1.19-5.el6

Comment 19 Fedora Update System 2014-11-12 23:17:39 UTC
perl-Class-XSAccessor-1.19-5.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.