Bug 474981
| Summary: | Review Request: jcalendar - A Java date chooser bean for graphically picking a date | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sandro Mathys <red> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, mtasaka, notting, sandro |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-01-09 14:59:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 475017 | ||
|
Description
Sandro Mathys
2008-12-06 11:05:37 UTC
Successfully created a mock-(re)build of this version of this pkg. Some notes
* Versioning
- As this does not seem to be a "pre-release" of version
1.3.2, you should not use "0." for release number.
* License
- For this package the license tag must be "LGPLv2+"
* BuildRequires/Requires
- Please follow
https://fedoraproject.org/wiki/Packaging/Java#BuildRequires_and_Requires
! Timestamp
- Preserving the original timestamp on jcalendar-license.txt
is preferred.
* Directory ownership issue
- This package should not own %_javadir.
(In reply to comment #2) > ! Timestamp > - Preserving the original timestamp on jcalendar-license.txt > is preferred. like... sed -i -e 's|\r||' jcalendar-license.txt > tmp touch -r jcalendar-license.txt tmp mv -f tmp jcalendar-license.txt Spec URL: http://red.fedorapeople.org/SRPMS/jcalendar.spec SRPM URL: http://red.fedorapeople.org/SRPMS/jcalendar-1.3.2-1.fc10.src.rpm Thanks for the comments! Everything has been addressed in the new version. The given script for preserving the timestamp while remove all \r didn't work but I got the idea and was able to come up with this: %{__sed} -i.tmp 's/\r//' jcalendar-license.txt touch -r jcalendar-license.txt.tmp jcalendar-license.txt This does what was intended I think...and is even a little bit shorter. Okay, no problem. ----------------------------------------------------- This package (jcalendar) is APPROVED by mtasaka ----------------------------------------------------- Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Install the Client Tools (Koji) ". Now I am sponsoring you. If you want to import this package into Fedora 9/10, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system). Note that now you are using red_AT_fedoraproject.org as bugzilla account, but using sm_AT_XXXXXX as FAS account mail address. To set fedora-cvs flag (this is needed for review process, which is written in "Join" wiki) or fedora-review flag (if you want to review other person's review request), you have to create bugzilla account with sm_AT_XXXXX mail address (if not exist) and login bugzilla as sm_AT_XXXXX account. If you have some question, please ask me. Removing NEEDSPONSOR If you have questions, please ask me. I already had this account...I didn't even remember :D Uhm, do I need to do anything on my review requests with this account now? I think I can't change the 'reporter' or can I? Thanks again for your help. I'll also update my other review requests since pretty every package matches the problems from comment #2. I've actually already fixed that locally but I'll need to update the requests when I find the time to do so....just saying this before you posts the problems from #2 everywhere ;) New Package CVS Request ======================= Package Name: jcalendar Short Description: A Java date chooser bean for graphically picking a date Owners: red Branches: F-9 F-10 InitialCC: cvs done. ping? jcalendar-1.3.2-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/jcalendar-1.3.2-1.fc10 jcalendar-1.3.2-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/jcalendar-1.3.2-1.fc9 Okay, thanks. jcalendar-1.3.2-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. jcalendar-1.3.2-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |