Bug 474985

Summary: Review Request: jakarta-commons-compress - API for working with tar, zip and bzip2 files
Product: [Fedora] Fedora Reporter: Sandro Mathys <red>
Component: Package ReviewAssignee: Conrad Meyer <cse.cem+redhatbugz>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: cse.cem+redhatbugz, fedora-package-review, notting, sandro
Target Milestone: ---Flags: cse.cem+redhatbugz: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-01-29 23:03:07 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 472144    
Attachments:
Description Flags
[Review] none

Description Sandro Mathys 2008-12-06 11:42:51 UTC 
Spec URL: http://red.fedorapeople.org/SRPMS/jakarta-commons-compress.spec
SRPM URL: http://red.fedorapeople.org/SRPMS/jakarta-commons-compress-20081205-0.1.fc10.src.rpm
Description: The code in this component came from Avalon's Excalibur, but originally
from Ant, as far as life in Apache goes. The tar package is originally
Tim Endres' public domain package. The bzip2 package is based on the
work done by Keiron Liddle. It has migrated via:
Ant -> Avalon-Excalibur -> Commons-IO -> Commons-Compress.

This  is a dependency needed for tvbrowser, for which a review request exists
already.

rpmlint on spec, srpm and noarch-rpms finishes checking without any warnings or
errors.

A SVN-checkout/-tarball is necessary because commons-compress is still in its 'sandbox', where upstream does not create tarballs of any sort. This will only change once it becomes mature.

I'd still need a sponsor.
Comment 1 Sandro Mathys 2008-12-12 01:02:14 UTC 
Successfully created a mock-(re)build of this version of this pkg.
Comment 2 Mamoru TASAKA 2008-12-15 15:03:08 UTC 
(Removing NEEDSPONSOR)
Comment 3 Sandro Mathys 2008-12-16 04:29:41 UTC 
Spec URL: http://red.fedorapeople.org/SRPMS/jakarta-commons-compress.spec
SRPM URL: http://red.fedorapeople.org/SRPMS/jakarta-commons-compress-20081205-1.fc10.src.rpm

New version including much of the experience I got when my jcalendar pkg was
reviewed.
Comment 4 Conrad Meyer 2008-12-16 13:03:08 UTC 
Created attachment 327099 [details]
[Review]

See attached for my initial review of the package.

I need a reason for building the jar manually instead of using maven before approving this (or alternatively, you can switch the spec over to build using maven (pom.xml) as documented at [0] and [1]).

[0]: https://fedoraproject.org/wiki/Packaging/Java#maven
[1]: https://fedoraproject.org/wiki/Packaging/Java#maven_2
Comment 5 Sandro Mathys 2008-12-16 17:12:25 UTC 
Thanks for the review.

Actually, maven needs artifacts that are not provided in Fedora. And packaging other java software that could be built using maven also shows that maven is Fedora lacks lots of important artifacts and that maven is really outdated. And I really don't understand maven enough to change any of this.
Comment 6 Conrad Meyer 2008-12-16 22:43:15 UTC 
That is a perfectly legitimate reason not to use maven for me. Please fix the other things in the review.
Comment 7 Sandro Mathys 2008-12-17 00:01:18 UTC 
I'm about to perform the necessary changes.

Is it a problem to have the svn information included? Makes it somewhat easier to maintain as I only need to unpack it, svn up, repack it and do a new build.

Including the date when the snapshot was done in the release tag is a problem:
jakarta-commons-compress-javadoc.noarch: W: filename-too-long-for-joliet jakarta-commons-compress-javadoc-0-0.1.20081205svn.fc11.noarch.rpm

...what should I do about this?
Comment 8 Conrad Meyer 2008-12-17 00:17:30 UTC 
(In reply to comment #7)
> I'm about to perform the necessary changes.
> 
> Is it a problem to have the svn information included? Makes it somewhat easier
> to maintain as I only need to unpack it, svn up, repack it and do a new build.

Sure, if that works for you that's fine.

> Including the date when the snapshot was done in the release tag is a problem:
> jakarta-commons-compress-javadoc.noarch: W: filename-too-long-for-joliet
> jakarta-commons-compress-javadoc-0-0.1.20081205svn.fc11.noarch.rpm
> 
> ...what should I do about this?

dwmw2 says this is not an issue, I believe him :).
Comment 9 Sandro Mathys 2008-12-17 00:33:26 UTC 
Spec URL: http://red.fedorapeople.org/SRPMS/jakarta-commons-compress.spec
SRPM URL:
http://red.fedorapeople.org/SRPMS/jakarta-commons-compress-0-0.1.20081205svn727209.fc11.src.rpm

I think every issue was addressed.
Comment 10 Conrad Meyer 2008-12-17 00:40:52 UTC 
Looks good. APPROVED.
Comment 11 Sandro Mathys 2008-12-17 00:44:54 UTC 
New Package CVS Request
=======================
Package Name: jakarta-commons-compress
Short Description: Java API for working with tar, zip and bzip2 files
Owners: red
Branches: F-9 F-10
InitialCC:
Comment 12 Kevin Fenzi 2008-12-18 00:14:31 UTC 
cvs done.
Comment 13 Fedora Update System 2009-01-09 11:49:54 UTC 
jakarta-commons-compress-0-0.1.20081205svn727209.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/jakarta-commons-compress-0-0.1.20081205svn727209.fc9
Comment 14 Fedora Update System 2009-01-09 11:51:43 UTC 
jakarta-commons-compress-0-0.1.20081205svn727209.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/jakarta-commons-compress-0-0.1.20081205svn727209.fc10
Comment 15 Fedora Update System 2009-01-15 02:54:03 UTC 
jakarta-commons-compress-0-0.1.20081205svn727209.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update jakarta-commons-compress'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0392
Comment 16 Fedora Update System 2009-01-15 03:04:40 UTC 
jakarta-commons-compress-0-0.1.20081205svn727209.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing-newkey update jakarta-commons-compress'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-0514
Comment 17 Fedora Update System 2009-01-29 23:03:04 UTC 
jakarta-commons-compress-0-0.1.20081205svn727209.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 18 Fedora Update System 2009-01-29 23:04:49 UTC 
jakarta-commons-compress-0-0.1.20081205svn727209.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.