Bug 475005

Summary: python-2.5.2-set_wakeup_fd4.patch is not what went upstream
Product: [Fedora] Fedora Reporter: Daniel Drake <dsd>
Component: pythonAssignee: James Antill <james.antill>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 10CC: ivazqueznet, james.antill, jonathansteffan, katzj, pbrobinson
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-07-04 11:34:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 462625    
Attachments:
Description Flags
new patch none

Description Daniel Drake 2008-12-06 16:16:15 UTC 
python-2.5.2-1.fc10 includes a patch titled python-2.5.2-set_wakeup_fd4.patch which came from http://bugs.python.org/issue1583

However, the final patch on that bug (and the one that is included in F10) is not the version that went upstream. The version that went upstream adds a C API. I'm attaching the final version, which should replace the current patch.

This is needed to decrease wakeups in PyGTK programs:
http://blogs.gnome.org/johan/2008/01/04/enough-wakeups-in-python-programs/

[sidenote, PyGTK also needs fixing, which I'm working on at http://bugzilla.gnome.org/show_bug.cgi?id=481569 )

First step is to fix Python though. Please commit the updated patch, or let me know that it's OK for me to do so.
Comment 1 Daniel Drake 2008-12-06 16:17:03 UTC 
Created attachment 326003 [details]
new patch
Comment 2 Ignacio Vazquez-Abrams 2008-12-07 05:50:34 UTC 
It doesn't break the existing API, so I've applied it in cvs.
Comment 3 Peter Robinson 2009-04-11 19:33:39 UTC 
Can this now be closed?