Bug 475135
| Summary: | Review Request: portmidi - Real-time Midi I/O Library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orcan Ogetbil <oget.fedora> |
| Component: | Package Review | Assignee: | Lucian Langa <lucilanga> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lucilanga, mjg, notting |
| Target Milestone: | --- | Flags: | lucilanga:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-10-06 16:52:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Orcan Ogetbil
2008-12-08 03:45:50 UTC
New upstream release Spec URL: http://oget.fedorapeople.org/review/portmidi.spec SRPM URL: http://oget.fedorapeople.org/review/portmidi-131-1.fc10.src.rpm Review:
OK specfile is properly named, is cleanly written and uses macros consistently.
OK summary is OK.
OK description is OK.
OK dist tag is present.
OK build root is OK.
OK license field matches the actual license.
OK license is open source-compatible.
OK license text included in package.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (rawhide, x86_64).
OK package installs properly.
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires are sane:
portmidi-131-1.fc11.x86_64.rpm
libportmidi.so.0()(64bit)
libporttime.so.0()(64bit)
portmidi = 131-1.fc11
portmidi(x86-64) = 131-1.fc11
=
/sbin/ldconfig
libasound.so.2()(64bit)
libc.so.6()(64bit)
libm.so.6()(64bit)
libportmidi.so.0()(64bit)
libporttime.so.0()(64bit)
libpthread.so.0()(64bit)
portmidi-devel-131-1.fc11.x86_64.rpm
portmidi-devel = 131-1.fc11
portmidi-devel(x86-64) = 131-1.fc11
=
libportmidi.so.0()(64bit)
libporttime.so.0()(64bit)
portmidi = 131-1.fc11
OK %check is not present; no test suite upstream.
OK shared libraries installed; ldconfig called properly
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK code, not content.
OK documentation is small, so no -doc subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers are in a separate -devel package.
OK no pkgconfig files.
OK no static libraries.
OK no libtool .la files.
Suggestions:
- There is a doxygen style documentation provided in this package, you should include it in the -devel and don't forget to pickup doxygen as a BR.
- Please consider preserving timestamps of installed files
APPROVED.
> Suggestions:
>
> - There is a doxygen style documentation provided in this package, you should
> include it in the -devel and don't forget to pickup doxygen as a BR.
> - Please consider preserving timestamps of installed files
>
> APPROVED.
Thanks! Will do.
New Package CVS Request
=======================
Package Name: portmidi
Short Description: Real-time Midi I/O Library
Owners: oget
Branches: F-10
InitialCC:
cvs done. portmidi-131-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update portmidi'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1149 Package Change Request ====================== Package Name: portmidi New Branches: el6 Owners: mjg As the Fedora maintainer of portmidi, I am fine with Michael maintaining it on EPEL. Git done (by process-git-requests). |