Bug 475472

Summary: bugzilla: misplaced #add_comment anchor
Product: [Community] Bugzilla Reporter: Tomas Hoger <thoger>
Component: User InterfaceAssignee: Noura El hawary <nelhawar>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: develCC: nelhawar
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-12-11 01:34:08 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
v1 changing comment anchor dkl: review+

Description Tomas Hoger 2008-12-09 12:20:51 UTC 
Description of problem:
When someone hits "[Reply]" link for some comment, "Additional Comments" text area is pre-filled >-quoted comment text and location is changed to show_bug.cgi?id=<id>#add_comment.  However, the add_comment anchor is placed on the top of the page, right below "External Bugs" section, while input text area is at the bottom.  So the browser is likely to scroll page to the part where there's no input area to fill comment to, forcing user to scroll down again, which is quite annoying for longer bugs.

Additional info:
IIRC, placement of "Additional Comments" below existing comments is a diversion from upstream default.  The anchor needs to be moved accordingly as well.
Comment 1 Noura El hawary 2008-12-10 14:53:10 UTC 
Created attachment 326515 [details]
v1 changing comment anchor

Thanks for reporting this issue Thomas, attached is patch for the fix.

Noura
Comment 2 David Lawrence 2008-12-10 18:21:17 UTC 
Comment on attachment 326515 [details]
v1 changing comment anchor

>Index: template/en/default/bug/edit.html.tmpl
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/template/en/default/bug/edit.html.tmpl,v
>retrieving revision 1.61
>diff -p -u -r1.61 edit.html.tmpl
>--- template/en/default/bug/edit.html.tmpl	5 Dec 2008 20:21:55 -0000	1.61
>+++ template/en/default/bug/edit.html.tmpl	10 Dec 2008 14:51:54 -0000
>@@ -254,7 +254,6 @@
>     <tr>
>       <td id="comment_status_commit">
>         <!-- The table keeps the commit button aligned with the box. -->
>-        <a name="add_comment"></a>
>         [%# REDHAT EXTENSION START 462473 %]
>         [% sort_order = user.settings.comment_sort_order.value %]
> 
>@@ -273,6 +272,7 @@
>         [%# REDHAT EXTENSION START 457022 %]
>         [% IF user.id %]
>           <table><tr><td>
>+          <a name="add_comment"></a>
>           <label for="comment" accesskey="c"><b>Additional <u>C</u>omments</b></label>:
>           [% IF user.is_insider %]
>             <input type="checkbox" name="commentprivacy" value="1"
>

To be more in sync with where upstream has the anchor, move it to right about the [% IF user.id %] line.

>+        <a name="add_comment"></a>
>         [%# REDHAT EXTENSION START 457022 %]
>         [% IF user.id %]
>           <table><tr><td>
>           <label for="comment" accesskey="c"><b>Additional <u>C</u>omments</b></label>:
>           [% IF user.is_insider %]
>             <input type="checkbox" name="commentprivacy" value="1"

After that, review+.

Dave
Comment 3 Noura El hawary 2008-12-11 01:34:08 UTC 
moved the anchor as you suggested Dave and committed to cvs. should be live next bugzilla update which happens every Thursday.

Noura