Bug 475777

Summary:	Review Request: perl-AnyEvent-AIO - Truly asynchronous file and directory I/O
Product:	[Fedora] Fedora	Reporter:	Nicolas Chauvet (kwizart) <kwizart>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	j: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-12-19 15:54:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nicolas Chauvet (kwizart) 2008-12-10 12:55:53 UTC

Spec URL:
http://kwizart.fedorapeople.org/SPECS/perl-AnyEvent-AIO.spec
SRPM URL:
http://kwizart.fedorapeople.org/SRPMS/perl-AnyEvent-AIO-1.0-1.fc11.src.rpm
Description: Truly asynchronous file and directrory I/O

rpmlint is clean
built using mock on rawhide-i386

This package needs an updated perl(IO::AIO) (>= 3 ) currently in updates-testing for F-10 (whereas it should works for F-9)

Comment 1 Jason Tibbitts 2008-12-10 23:06:51 UTC

"directrory" should be spelled "directory" in Summary: and %description.  Not a big deal; just fix it up when you check in.

* source files match upstream.  sha256sum:
  88788b422f9f0d6664d97ec876631309726d803abf758b903a9530746b66c8ed  
   AnyEvent-AIO-1.0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
O summary is OK (spelling).
O description is OK (spelling).
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(AnyEvent::AIO) = 1.0
   perl-AnyEvent-AIO = 1.0-1.fc11
  =
   perl(:MODULE_COMPAT_5.10.0)
   perl(AnyEvent)
   perl(IO::AIO)
   perl(base)
   perl(strict)

* %check is present and all tests pass:
  All tests successful.
  Files=1, Tests=1,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.01 cusr  0.00 
   csys =  0.02 CPU)

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

Comment 2 Nicolas Chauvet (kwizart) 2008-12-11 14:40:51 UTC

Thx for the reviews tibbs. I will fix the typo before import.

Comment 3 Nicolas Chauvet (kwizart) 2008-12-11 14:43:54 UTC

New Package CVS Request
=======================
Package Name: perl-AnyEvent-AIO
Short Description: Truly asynchronous file and directory I/O
Owners: kwizart
Branches: F-10 F-9 EL-5
InitialCC: perl-sig
Cvsextras Commits: yes

Comment 4 Kevin Fenzi 2008-12-14 05:16:54 UTC

cvs done.