Bug 475799 (pidgin-musictracker)
| Summary: | Review Request: pidgin-musictracker - Pidgin displays the musictrack currently playing in your status | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Julio Cezar <watchman7> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, itamar, jan.klepek, jon.turney, mail, notting, susi.lehtola, zhenyaZhukova |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-04-08 22:26:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Julio Cezar
2008-12-10 15:17:57 UTC
There is already an open review request for pidgin-musictracker. https://bugzilla.redhat.com/show_bug.cgi?id=469080 But it seems that the original reporter is no longer interested to maintain this package. *** Bug 475806 has been marked as a duplicate of this bug. *** Hosting on rapidshare.com is not really the best idea. I'd say (based on the COPYING file, which is referenced by the README file, source files do not include any license info ) that license should be GPLv2+ You should not build and package the static libraries and libtool archives. IF they are needed, separate packages should be used. And note that this program has already been submitted as #469080 *** Bug 475822 has been marked as a duplicate of this bug. *** *** Bug 475835 has been marked as a duplicate of this bug. *** *** Bug 475857 has been marked as a duplicate of this bug. *** *** Bug 475858 has been marked as a duplicate of this bug. *** Fabian, do i must waiting for Jon Hermansen pronounce ? *** Bug 475833 has been marked as a duplicate of this bug. *** Julio, let's wait some days for an answer from Jon, OK? This is your first package and you are seeking a sponsor. In the meantime you can submit other review requests for packages or even better make some informal review of other packages by yourself. https://fedoraproject.org/wiki/Packaging/ReviewGuidelines There is no answer from the reporter of the other pidgin-musictracker review request so far. https://bugzilla.redhat.com/show_bug.cgi?id=469080 I will close the other review request. Some comments on your spec file - License: GPLv2 What's is about the copyright in the NEWS file? - 'Source0: http://pidgin-musictracker.googlecode.com/files/pidgin-musictracker-0.4.4.tar.bz2' can be 'http://pidgin-musictracker.googlecode.com/files/musictracker-%{version}.tar.bz2' no worries about the version in the future to get the source - No 'BuildRequires' ? I think that this didn't work in mock. - This is a pidgin plugin but Pidgin is not a requirement? - 'make install DESTDIR=$RPM_BUILD_ROOT' better use 'make DESTDIR=%{buildroot} INSTALL="install -p" install' to preserves the files' timestamps. - '%doc AUTHORS ChangeLog COPYING NEWS README' The file THANKS is missing - For your file section, take a lot at https://fedoraproject.org/wiki/Packaging/Guidelines#Exclusion_of_Static_Libraries https://fedoraproject.org/wiki/Packaging/Guidelines#Relocatable_packages https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros - Your %changelog don't match the guidelines https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs ping? (In reply to comment #14) > ping? pong. What can i do to be the Package Maintainer for this package ? Very useful files search engine. <a href=http://indexoffiles.com>Indexoffiles.com </a> is a search engine designed to search files in various file sharing and uploading sites Julio, incorporate the the changes suggested in Comment #13, sooner or later somebody will make a full review and go on with the steps mentioned at https://fedoraproject.org/wiki/PackageMaintainers/Join . To get sponsored: https://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Any progress on this bug? Is this review dead? latest version of pidgin-musictracker repackaged here: https://bugzilla.redhat.com/show_bug.cgi?id=494857 Julio hasn't responded for many months, closing this as duplicate. *** This bug has been marked as a duplicate of bug 494857 *** |