Bug 475860 (libmsn)
| Summary: | Review Request: libmsn - Library for connecting to the MSN Messenger service | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | john5342 <john5342> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, itamar, john5342, jreznik, notting, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-01-29 23:04:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
john5342
2008-12-10 20:25:10 UTC
Incoherent version - in changelog you have 4.0-0.1-beta1 and version is 4.0-0.1.beta1 Mentioning "Microsoft" by name, makes me nervous, we probably want to (tm) those in the least, perhaps remove/omit them at most. working SRPM URL: (: http://john5342.fedorapeople.org/rpms/libmsn-4.0-0.1.beta1.fc10.src.rpm koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=991946 >Incoherent version - in changelog you have 4.0-0.1-beta1 and version is >4.0-0.1.beta1 Fixed. Saw the fc10 and had no idea how to make that scale but completely missed the full-stop/hyphen mixup in there. >Mentioning "Microsoft" by name, makes me nervous, we probably want to (tm) >those in the least, perhaps remove/omit them at most. Fixed. Replaced with "the MSN protocol" as opposed to "Microsoft's MSN protocol". The _correct_ SRPM url this time (sorry about that): http://john5342.fedorapeople.org/rpms/libmsn-4.0-0.2.beta1.fc10.src.rpm The spec file is the same url: http://john5342.fedorapeople.org/rpms/libmsn.spec Updated bug title to reflect new package summary I'll pretend I didn't just think about MSN(tm) either, and just start reviewing. :) Clean, simple package. Use of macros correct, consistent. Confirmed need for patch (eew). My only minor suggestions would be to not include README, COPYING in -devel (it's already in main pkg), and to add %doc THANKS (can be done post review). APPROVED. New Package CVS Request ======================= Package Name: libmsn Short Description: Library for connecting to the MSN(tm) Messenger service Owners: john5342 Branches: F-9 F-10 InitialCC: CVS Done libmsn-4.0-0.3.beta1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/libmsn-4.0-0.3.beta1.fc9 libmsn-4.0-0.3.beta1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/libmsn-4.0-0.3.beta1.fc10 libmsn-4.0-0.3.beta1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libmsn'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2008-11570 libmsn-4.0-0.3.beta1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update libmsn'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-11505 libmsn-4.0-0.10.beta4.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libmsn'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0974 libmsn-4.0-0.10.beta4.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update libmsn'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-1012 libmsn-4.0-0.10.beta4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. libmsn-4.0-0.10.beta4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |