Bug 475962
| Summary: | Review Request: mitter - A maemo/GTK+ client for twitter | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lev Shamardin <shamardin> | ||||
| Component: | Package Review | Assignee: | Conrad Meyer <cse.cem+redhatbugz> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | cse.cem+redhatbugz, fedora-package-review, mail, notting | ||||
| Target Milestone: | --- | Flags: | cse.cem+redhatbugz:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-12-30 23:51:27 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Lev Shamardin
2008-12-11 10:53:44 UTC
Created attachment 327234 [details]
[Review]
Attached is my initial review for the package.
Also: please consider updating from Fedora 8 before it goes End of Line very soon!
Two very simple "BAD"s to fix and then I'll approve this.
Something about the .desktop file 'desktop-file-install --vendor="fedora" \' is obsolete for new packages https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor In that case someone needs to fix http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files . In the mean time, you only have one thing to fix and I'll approve :). And it's a very minor thing -- very clean package. I've updated the .spec file and rpms: Spec URL: http://abbot.fedorapeople.org/mitter.spec SRPM URL: http://abbot.fedorapeople.org/mitter-0.4.3-1.fc8.src.rpm Changed the license to GPLv3+ and changed the desktop-file-install command to desktop-file-install --dir=%{buildroot}%{_datadir}/applications %{name}.desktop (removed --vendor "" option) Ok, looks good. APPROVED. New Package CVS Request ======================= Package Name: mitter Short Description: mitter - A maemo/GTK+ client for twitter Owners: abbot Branches: F-9 F-10 cvs done. mitter-0.4.3-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/mitter-0.4.3-1.fc10 mitter-0.4.3-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/mitter-0.4.3-1.fc9 mitter-0.4.3-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. mitter-0.4.3-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |