Bug 476324

Summary:	Review Request: perl-URI-Find - Find URIs in plain text
Product:	[Fedora] Fedora	Reporter:	Chris Weyl <cweyl>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, notting, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/URI-Find
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-12-14 19:09:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Chris Weyl 2008-12-13 01:56:48 UTC

Spec URL: http://fedorapeople.org/~cweyl/review/perl-URI-Find.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-URI-Find-0.16-1.fc10.src.rpm

Description:
This module does one thing: Finds URIs and URLs in plain text. It finds
them quickly and it finds them *all* (or what URI::URL considers a URI to
be.) It only finds URIs which include a scheme (http:// or the like), for
something a bit less strict have a look at URI::Find::Schemeless.

For a command-line interface, see Darren Chamberlain's 'urifind' script.
It's available from his CPAN directory, the
http://www.cpan.org/authors/id/D/DA/DARREN/ manpage.

Public Methods
    * *new*


Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=996047

Comment 1 Parag AN(पराग) 2008-12-13 10:54:42 UTC

Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=996047
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
339279e268cf37e629f54c1091f99a13  URI-Find-0.16.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
All tests successful.
Files=2, Tests=382,  0 wallclock secs ( 0.08 usr  0.01 sys +  0.09 cusr  0.04 csys =  0.22 CPU)
+ Package perl-URI-Find-0.16-1.fc11 =>
  Provides: perl(URI::Find) = 0.16 perl(URI::Find::Schemeless) = 1.8
  Requires: perl >= 0:5.005 perl(Carp) perl(URI) perl(URI::Find) perl(URI::URL) perl(base) perl(constant) perl(strict) perl(vars)

APPROVED.

Comment 2 Chris Weyl 2008-12-13 20:02:22 UTC

New Package CVS Request
=======================
Package Name: perl-URI-Find
Short Description: Find URIs in plain text
Owners: cweyl
Branches: F-9 F-10 devel
InitialCC:

Comment 3 Kevin Fenzi 2008-12-14 05:38:20 UTC

cvs done.