Bug 476351

Summary: Review Request: palp - A Package for Analyzing Lattice Polytopes
Product: [Fedora] Fedora Reporter: Conrad Meyer <konrad>
Component: Package ReviewAssignee: David Cantrell <dcantrell>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: dcantrell, fedora-package-review, notting
Target Milestone: ---Flags: jkeating: fedora‑review+
kevin: fedora‑cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-12-14 01:06:55 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Conrad Meyer 2008-12-13 07:47:02 EST
Spec URL: http://konradm.fedorapeople.org/fedora/SPECS/palp.spec
SRPM URL: http://konradm.fedorapeople.org/fedora/SRPMS/palp-1.1-1.fc9.src.rpm
Description:
PALP contains routines for vertex and facet enumeration, computation of
incidences and symmetries, as well as completion of the set of lattice
points in the convex hull of a given set of points. In addition, there
are procedures specialised to reflexive polytopes such as the enumeration
of reflexive subpolytopes, and applications to toric geometry and string
theory, like the computation of Hodge data and fibration structures for
toric Calabi-Yau varieties.
Comment 1 Conrad Meyer 2008-12-13 07:50:49 EST
Koji scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=996541
Comment 2 Jesse Keating 2008-12-13 15:03:32 EST
* Name fine
* Summary/description OK
* Group OK
* Source matches upstream
* Buildroot sane
* Make uses smp flags
* Install has clean
* Consistent use of macros
* %clean section OK
* defatter exists
* Changelog sane
* Build in mock for rawhide
* rpmlint is silent
* License is not OK
  Source refers to http://www.gnu.org/copyleft/gpl.html as it's license, which is now version 3, so I do believe the license needs to be GPLv3+
Comment 4 Jesse Keating 2008-12-13 16:03:05 EST
Looks good to me!
Comment 5 Conrad Meyer 2008-12-13 16:10:49 EST
Thanks!

New Package CVS Request
=======================
Package Name: palp
Short Description: A Package for Analyzing Lattice Polytopes
Owners: konradm
Branches: F-10 F-9
InitialCC:
Comment 6 Kevin Fenzi 2008-12-13 23:51:25 EST
cvs done.
Comment 7 Conrad Meyer 2008-12-14 01:06:11 EST
Built in rawhide. Closing.

http://koji.fedoraproject.org/koji/taskinfo?taskID=997464