Bug 476457

Summary: compiler complains about no return statement in code from linux-2.6-silence-fbcon-logo.patch
Product: [Fedora] Fedora Reporter: Michael Young <m.a.young>
Component: kernelAssignee: Kernel Maintainer List <kernel-maint>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: kernel-maint, kmcmartin, quintela
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-02-26 22:17:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michael Young 2008-12-14 23:51:57 UTC
When trying to build an altered rawhide kernel in F10 I get the error
cc1: warnings being treated as errors
drivers/video/console/fbcon.c: In function 'quiet_logo':
drivers/video/console/fbcon.c:3603: error: no return statement in function returning non-void
make[3]: *** [drivers/video/console/fbcon.o] Error 1
The problem code is from linux-2.6-silence-fbcon-logo.patch, and the lines +static int __init quiet_logo(char *str)
+{
+       logo_shown = FBCON_LOGO_DONTSHOW;
+}
+
+early_param("quiet", quiet_logo);
+
and the compiler is clearly worried that this is a int function but you aren't returning anything.

Comment 1 Kyle McMartin 2009-02-26 22:17:32 UTC
fixt. thanks. :)