Bug 476623
| Summary: | Review Request: perl-Test-NeedsDisplay - Ensure that tests needing a display have one | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marcela Mašláňová <mmaslano> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, jplesnik, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
opensource: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Test-NeedsDisplay-1.07-9.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-01-12 06:42:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Marcela Mašláňová
2008-12-16 09:54:42 UTC
Review: + package builds in mock (rawhide i386). koji Build => koji is down currently. + rpmlint is silent for SRPM and for RPM. + source files match upstream url 63967780b12820a668fed932812f9327 Test-NeedsDisplay-1.05.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=4, Tests=2, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.13 cusr 0.02 csys = 0.18 CPU) + Package perl-Test-NeedsDisplay-1.05-1.fc11 Provides: perl(Test::NeedsDisplay) = 1.05 Requires: perl >= 0:5.006 perl(Config) perl(File::Spec) perl(strict) perl(vars) Suggestions: Drop unnecessary BR:perl >= 1:5.6.0 APPROVED. ping? New Package CVS Request ======================= Package Name: perl-Test-NeedsDisplay Short Description: Ensure that tests needing a display have one Owners: mmaslano Branches: F-10 InitialCC: perl-devel cvs done. Package Change Request ====================== Package Name: perl-Test-NeedsDisplay New Branches: epel7 Owners: ddick The request for epel7 is based on BZ#1159715 I am current maintainer of the package and I agree with it. Git done (by process-git-requests). perl-Test-NeedsDisplay-1.07-9.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-Test-NeedsDisplay-1.07-9.el7 perl-Test-NeedsDisplay-1.07-9.el7 has been pushed to the Fedora EPEL 7 stable repository. |