Bug 477149
| Summary: | Fix dependencies and directories in NetworkManager-openvpn | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Robinson <pbrobinson> |
| Component: | NetworkManager-openvpn | Assignee: | Dan Williams <dcbw> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | choeger, dcbw, steve, tim |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-01-08 04:18:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
NetworkManager-openvpn-0.7.0-17.svn4326.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/NetworkManager-openvpn-0.7.0-17.svn4326.fc10 Hi,
thanks for the report, I removed libpng-devel and added %{_datadir}/gnome-vpn-properties/openvpn/ see
https://admin.fedoraproject.org/updates/NetworkManager-openvpn-0.7.0-17.svn4326.fc10
I did not:
- remove libgnomeui: it is needed by the authentication module
- remove gtk: it is needed by authentication/configuration module
If you could clearify what you meant with "automatically determined" I could review that again.
NetworkManager-openvpn-0.7.0-17.svn4326.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/NetworkManager-openvpn-0.7.0-17.svn4326.fc9 NetworkManager-openvpn-0.7.0-17.svn4326.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update NetworkManager-openvpn'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-11629 NetworkManager-openvpn-0.7.0-17.svn4326.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update NetworkManager-openvpn'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2008-11662 Hi, Thanks for the response. > I did not: > > - remove libgnomeui: it is needed by the authentication module I'm not sure that it is needed, none of the actual source files include gnomeui.h, also NetworkManager itself and the NetworkManager-vpnc don't use or require libgnomeui > - remove gtk: it is needed by authentication/configuration module > > If you could clearify what you meant with "automatically determined" I could > review that again. See the details in the packaging guidelines [1]. Basically RPM can work out what libraries are linked to by an application and hence will automatically determine what libraries it needs to 'Require'. You need to include dbus as a require but the NetworkManager, gtk, gconf, gnome-keyring etc should be automatic. [1] https://fedoraproject.org/wiki/Packaging/Guidelines#Requires NetworkManager-0.7.0-1.git20090102.fc10,NetworkManager-vpnc-0.7.0-1.svn13.fc10,NetworkManager-openvpn-0.7.0-18.svn11.fc10,NetworkManager-pptp-0.7.0-1.svn16.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/NetworkManager-0.7.0-1.git20090102.fc10,NetworkManager-vpnc-0.7.0-1.svn13.fc10,NetworkManager-openvpn-0.7.0-18.svn11.fc10,NetworkManager-pptp-0.7.0-1.svn16.fc10 NetworkManager-0.7.0-1.git20090102.fc9,NetworkManager-vpnc-0.7.0-1.svn13.fc9,NetworkManager-openvpn-0.7.0-18.svn11.fc9,NetworkManager-pptp-0.7.0-1.svn16.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/NetworkManager-0.7.0-1.git20090102.fc9,NetworkManager-vpnc-0.7.0-1.svn13.fc9,NetworkManager-openvpn-0.7.0-18.svn11.fc9,NetworkManager-pptp-0.7.0-1.svn16.fc9 > - remove libgnomeui: it is needed by the authentication module See the fix put into NM-pptp for the details of this one http://svn.gnome.org/viewvc/network-manager-pptp/trunk/configure.in?r1=2&r2=8 NetworkManager-0.7.0-1.git20090102.fc10, NetworkManager-vpnc-0.7.0-1.svn13.fc10, NetworkManager-openvpn-0.7.0-18.svn11.fc10, NetworkManager-pptp-0.7.0-1.svn16.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update NetworkManager NetworkManager-vpnc NetworkManager-openvpn NetworkManager-pptp'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0023 NetworkManager-0.7.0-1.git20090102.fc9, NetworkManager-vpnc-0.7.0-1.svn13.fc9, NetworkManager-openvpn-0.7.0-18.svn11.fc9, NetworkManager-pptp-0.7.0-1.svn16.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update NetworkManager NetworkManager-vpnc NetworkManager-openvpn NetworkManager-pptp'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-0222 NetworkManager-0.7.0-1.git20090102.fc10, NetworkManager-vpnc-0.7.0-1.svn13.fc10, NetworkManager-openvpn-0.7.0-18.svn11.fc10, NetworkManager-pptp-0.7.0-1.svn16.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. NetworkManager-0.7.0.99-1.fc9,NetworkManager-vpnc-0.7.0.99-1.fc9,NetworkManager-openvpn-0.7.0.99-1.fc9,NetworkManager-pptp-0.7.0.99-1.fc9,NetworkManager-openconnect-0.7.0.99-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/NetworkManager-0.7.0.99-1.fc9,NetworkManager-vpnc-0.7.0.99-1.fc9,NetworkManager-openvpn-0.7.0.99-1.fc9,NetworkManager-pptp-0.7.0.99-1.fc9,NetworkManager-openconnect-0.7.0.99-1.fc9 NetworkManager-0.7.0.99-1.fc9, NetworkManager-vpnc-0.7.0.99-1.fc9, NetworkManager-openvpn-0.7.0.99-1.fc9, NetworkManager-pptp-0.7.0.99-1.fc9, NetworkManager-openconnect-0.7.0.99-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |
There's a few issues with the .spec file that could be cleaned up. libpng is not used so is an unneeded BuildReq BuildRequires: libpng-devel NM-openvpn needs to own the following dir %{_datadir}/gnome-vpn-properties/openvpn/ This needs a fix upstream too but NM-openvpn doesn't use libgnomeui but checks for it unnecessarily in the configure check. Once that's fixed the following BuildReq can be dropped. BuildRequires: libgnomeui-devel Alot of the actual Requires could also be dropped as things like gtk will be automatically determined.