Bug 477221

Summary:	Review Request: qzion - QZion is an canvas abstraction used by and made for QEdje
Product:	[Fedora] Fedora	Reporter:	john5342 <john5342>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, rdieter
Target Milestone:	---	Flags:	rdieter: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-12-24 18:39:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	477223

Description john5342 2008-12-19 18:22:35 UTC

Spec URL: http://john5342.fedorapeople.org/rpms/qzion.spec
SRPM URL: http://john5342.fedorapeople.org/rpms/qzion-0.3.0-1.fc10.src.rpm
Description: QZion is an canvas abstraction used by and made for QEdje.

This package is a requirement of qedje which will be submitted shortly.

rpmlint output is:
qzion-devel.x86_64: W: no-documentation
appropriate docs are provided in main package which is required by qzion-devel

Comment 1 Rex Dieter 2008-12-19 19:05:32 UTC

I'll take a gander

Comment 2 Rex Dieter 2008-12-19 21:11:18 UTC

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1010198

$ rpmlint *.rpm
qzion-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

Simple library-only package, so only a few minor comments:

1.  BR: qt4-devel is preferable

2.  BR: pkgconfig (so F11+'s rpm can do automatic pkgconfig-related deps).

3.  License: GPLv3+
files all contain the "or (at your option) any later version." clause

sources: ok
patches: ok
scriptlets: ok
macros: ok

I'll leave the minor items 1-3 to you to fix prior to building.

APPROVED.

Comment 3 Rex Dieter 2008-12-19 21:18:19 UTC

Oh, and let me suggest a shorter summary, something like:
A canvas abstraction
(including the pkg's name and the phrase "used by and made for..." is superfluous imo)

Comment 4 john5342 2008-12-19 21:20:13 UTC

New Package CVS Request
=======================
Package Name: qzion
Short Description: A canvas abstraction
Owners: john5342
Branches: F-9 F-10
InitialCC:

Comment 5 Kevin Fenzi 2008-12-21 04:28:38 UTC

cvs done.

Comment 6 Fedora Update System 2008-12-22 14:07:46 UTC

qedje-0.3.0-2.fc10,qzion-0.3.0-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/qedje-0.3.0-2.fc10,qzion-0.3.0-2.fc10

Comment 7 Fedora Update System 2008-12-24 18:39:27 UTC

qedje-0.3.0-2.fc10, qzion-0.3.0-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2009-01-29 23:06:44 UTC

qedje-0.3.0-2.fc9, qzion-0.3.0-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.