Bug 477223

Summary:	Review Request: qedje - A library combining the benefits of Edje and Qt
Product:	[Fedora] Fedora	Reporter:	john5342 <john5342>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, rdieter
Target Milestone:	---	Flags:	rdieter: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-12-24 18:39:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	477221
Bug Blocks:

Description john5342 2008-12-19 18:28:02 UTC

Spec URL: http://john5342.fedorapeople.org/rpms/qedje.spec
SRPM URL: http://john5342.fedorapeople.org/rpms/qedje-0.3.0-1.fc10.src.rpm
Description: 
The main purpose of the QEdje project is to build a bridge among components
that proved to have great value for open source developers: Edje and Qt. This
will extend the Qt toolkit with the flexibility of a declarative language, such
as Edje, and also enable Qt widgets to be embedded into Edje UI design.


This package requires qzion which is also in review.

rpmlint output is:
qedje-devel.x86_64: W: no-documentation
appropriate docs are provided in main package which is required by qedje-devel

Comment 1 Rex Dieter 2008-12-19 21:19:54 UTC

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1010203

Comment 2 Rex Dieter 2008-12-19 21:26:59 UTC

guess the scratch build won't get for without qzion, which is:

missing BR: qzion-devel
:)

Otherwise, same general comments as per qzion review:
BR: qt4-devel
BR: pkgconfig
License: GPLv3+

sources: ok
patches: ok
scriptlets: ok
macros: ok

I'll leave these minor items to you to fix prior to building.

APPROVED.

Comment 3 john5342 2008-12-19 22:00:21 UTC

New Package CVS Request
=======================
Package Name: qedje
Short Description: A library combining the benefits of Edje and Qt
Owners: john5342
Branches: F-9 F-10
InitialCC:

Comment 4 Kevin Fenzi 2008-12-21 04:29:33 UTC

cvs done.

Comment 5 Fedora Update System 2008-12-22 14:07:49 UTC

qedje-0.3.0-2.fc10,qzion-0.3.0-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/qedje-0.3.0-2.fc10,qzion-0.3.0-2.fc10

Comment 6 Fedora Update System 2008-12-24 18:39:30 UTC

qedje-0.3.0-2.fc10, qzion-0.3.0-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2009-01-29 23:06:47 UTC

qedje-0.3.0-2.fc9, qzion-0.3.0-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.