Bug 477373
Summary: | Please convert to new font packaging guidelines | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nicolas Mailhot <nicolas.mailhot> | ||||
Component: | cjkuni-fonts | Assignee: | Caius Chance <K9> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | fonts-bugs, i18n-bugs, K9, petersen | ||||
Target Milestone: | --- | Keywords: | i18n, Reopened | ||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2009-02-04 01:18:23 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 253813 | ||||||
Bug Blocks: | 477044 | ||||||
Attachments: |
|
Description
Nicolas Mailhot
2008-12-21 00:24:53 UTC
[Since the bot made a mess of the text here it is again in properly indented form.] This bug has been filed because we've detected your package includes one or several font files: repoquery -C --repoid=rawhide -f '*.ttf' -f '*.otf' -f '*.pfb' -f '*.pfa' --qf='%{SOURCERPM}\n' |sed -e 's+-[0-9.-]*\.fc[123456789]\(.*\)src.rpm++g'|sort|uniq Unfortunately this script does not detect symlinks to other packages, so if that's your case, you can close this bug report now. Otherwise, you should know that: — Fedora guidelines demand the packaging of fonts in a separate package (or subpackage): http://fedoraproject.org/wiki/Packaging/Guidelines#Avoid_bundling_of_fonts_in_other_packages — our font packaging guidelines recently changed, and every package that ships fonts must be adapted to the new templates available in the fontpackages-devel package: – http://fedoraproject.org/wiki/PackagingDrafts/Fonts_packaging_automation_(2008-11-18) – http://fedoraproject.org/wiki/Fedora_fonts_policy_package – http://fedoraproject.org/wiki/Simple_fonts_spec_template – http://fedoraproject.org/wiki/Fonts_spec_template_for_multiple_fonts Please make your package conform to the current guidelines in rawhide (you can use the fontpackages package in F9 or F10 to test, but only submit changes to rawhide please). If your package is not principaly a font package, depending on a separate font package or subpackage is the prefered solution. If your application does not use fontconfig you can always package symlinks to the files provided by the font package and installed in the correct fontconfig directories. It is preferred to create a font package or subpackage per font family, though it is not currently a hard guidelines requirement (it may become before Fedora 11 is released). The definition of a font family is given on: http://fedoraproject.org/wiki/Fonts_spec_template_notes/font-family The new templates should make the creation of font subpackages easy and safe. The following packages have already been converted by their packager and can serve as examples: ❄ andika-fonts ❄ apanov-heuristica-fonts ❄ bitstream-vera-fonts ❄ charis-fonts ❄ dejavu-fonts ❄ ecolier-court-fonts ❄ edrip-fonts ❄ gfs-ambrosia-fonts ❄ gfs-artemisia-fonts ❄ gfs-baskerville-fonts ❄ gfs-bodoni-classic-fonts ❄ gfs-bodoni-fonts ❄ gfs-complutum-fonts ❄ gfs-didot-classic-fonts ❄ gfs-didot-fonts ❄ gfs-eustace-fonts ❄ gfs-fleischman-fonts ❄ gfs-garaldus-fonts ❄ gfs-gazis-fonts ❄ gfs-jackson-fonts ❄ gfs-neohellenic-fonts ❄ gfs-nicefore-fonts ❄ gfs-olga-fonts ❄ gfs-porson-fonts ❄ gfs-solomos-fonts ❄ gfs-theokritos-fonts ❄ stix-fonts ❄ yanone-kaffeesatz-fonts If you have any remaining questions about the new guidelines please ask them on: fedora-fonts-list at redhat.com (note that the macros used in the new templates are integral part of the new guidelines) Please use the %_font_pkg macro; its an integral part of the official font packaging guidelines. To help packagers manage the transition to the new guidelines, we've published the following FAQ http://fedoraproject.org/wiki/Shipping_fonts_in_other_packages_(FAQ) I added: %_font_pkg -n uming -f *-ttf-arphic-uming*.conf uming.ttc in .spec file. Then it isn't buildable since then with errors: rpmbuild --define "_sourcedir /home/cchance/src/fedora/rpms/cjkunifonts/devel" --define "_spmake: *** [noarch] Error 1 ora/rpms/cjkunifonts/devel" --define "_builddir /home/cchance/src/fedora/rpms/cjkunifonts/devel" --define "_srcrpmdir /home/cchance/src/fedora/rpms/cjkunifonts/devel" --define "_rpmdir /home/cchance/src/fedora/rpms/cjkunifonts/devel" --define "dist .fc11" --define "fedora 11" --define "fc11 1" --target noarch -ba cjkunifonts.spec 2>&1 | tee .build--.log ; exit ${PIPESTATUS[0]} error: line 142: Second %post Building target platforms: noarch Building for target noarch What would I need to do to get it work? Created attachment 328691 [details]
.spec w/ %_font_pkg but not buildable.
http://fedoraproject.org/wiki/Shipping_fonts_in_other_packages_%28FAQ%29#Where_is_the_rest_of_the_subpackaging_bits_in_spectemplate-fonts-multi.spec.3F http://fedoraproject.org/wiki/Shipping_fonts_in_other_packages_%28FAQ%29#What_happened_to_the_fc-cache_scriptlets_listed_in_previous_guidelines.3F http://fedoraproject.org/wiki/Shipping_fonts_in_other_packages_%28FAQ%29#The_templates_must_be_wrong.2C_rpm_crashes.21 built w/ macro used http://koji.fedoraproject.org/koji/buildinfo?buildID=78415 FPC requested much stricter font package naming rules so some naming changes are in order too (sorry) http://fedoraproject.org/wiki/Shipping_fonts_in_Fedora_(FAQ)#fpc_renaming Some additional QA comments (appart from the naming issue) — do not define a fontdir, use the %{_fontdir} provided by the fontpackages macro set — I think you'll find out if you check the descriptions of the resulting packages that they are a bit redundant — I'm almost certain Behdad would be horrified by all the legacy compat hackery cruft in this package. Please consider dropping some of it. Or at least move it to separate optional -compat packages — Please do not include the same files in the two subpackages; the multi-fonts official spec templates provides a common subpackage for this kind of stuff updated in cvs tree, requested rel-eng for fedora 11 tree of new package name https://bugzilla.redhat.com/show_bug.cgi?id=253813 Some comments on http://cvs.fedoraproject.org/viewvc/devel/cjkuni-fonts/cjkuni-fonts.spec?revision=1.1&view=markup 1. you do not need those in the -common subpackage or the fonts subpackages. Put them in the -compat subpackage only Conflicts: fonts-chinese <= 3.03-9.fc8 Obsoletes: fonts-chinese < 3.03-13 Obsoletes: ttfonts-zh_CN <= 2.14-10, ttfonts-zh_TW <= 2.11-28 2. your Obsoletes: %{name}-uming < 0.2.20080216.1-16 should be changed to Obsoletes: cjkunifonts-uming < 0.2.20080216.1-16 since your package %{name} is now cjkuni-fonts (same for ukai and compat) Didn't see anything else obvious, of course testing the upgrade path yourself once the package is built is the best way to catch problems changed to cjkuni-fonts because of new naming rules Patched in rawhide. |