Bug 477732
Summary: | Review Request: xfconf - Hierarchical configuration system for Xfce | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Kevin Fenzi <kevin> |
Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-01-13 02:23:56 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Kevin Fenzi
2008-12-23 05:29:17 UTC
Oops. I forgot to include gettext. Updated spec and src.rpm: Spec URL: http://www.scrye.com/~kevin/fedora/xfconf/xfconf.spec SRPM URL: http://www.scrye.com/~kevin/fedora/xfconf/xfconf-4.5.92-2.fc11.src.rpm OK source files match upstream: 1ca682571554c7704f4c09398b74529d OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field GPLv2 matches the actual license. OK license is open source-compatible. License text not included upstream. OK latest version is being packaged. OK BuildRequires are proper. OK %clean is present. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK rpmlint is ok: xfconf-devel.x86_64: W: no-documentation OK final provides and requires look sane. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK no duplicates in %files. OK file permissions are appropriate. OK scriptlets ok. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. xfconf-perl.x86_64: W: perl-temp-file /usr/lib64/perl5/5.10.0/x86_64-linux-thread-multi/perllocal.pod I'm not sure what to do with this file. I have on my computer in perllocal.pod only log from modules installed in /usr/local. So probably you should remove this file from your package. xfconf-perl.x86_64: E: zero-length /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Xfce4/Xfconf/Xfconf.bs If it's config file, you should mark it like config. xfconf-perl.x86_64: W: hidden-file-or-dir /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Xfce4/Xfconf/.packlist xfconf-perl.x86_64: W: perl-temp-file /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Xfce4/Xfconf/.packlist You should add into spec the same line as Perl packages have: find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \; xfconf-perl.x86_64: E: non-standard-executable-perm /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Xfce4/Xfconf/Xfconf.so 0555 The other perl *.so have permission 0755. xfconf-perl.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Xfce4/Xfconf/Install/xfconfperl-autogen.h xfconf-perl.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Xfce4/Xfconf/Install/xfconfperl.h In guidelines are no exception. You should create devel package. (In reply to comment #2) > xfconf-perl.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Xfce4/Xfconf/Install/xfconfperl-autogen.h > xfconf-perl.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Xfce4/Xfconf/Install/xfconfperl.h > In guidelines are no exception. You should create devel package. perl has this exception: https://fedoraproject.org/wiki/Packaging/Perl#.h_files_in_module_packages I forgot mention that you need review for libxfce4util-4.5.92 first. Hey Marcela. Thank you for the quick review! >I forgot mention that you need review for libxfce4util-4.5.92 first. libxfce4util is already in fedora, it's just that this package needs the version from the Xfce 4.6 beta2 release. I am planning on updating it in rawhide, but wanted to get the new packages reviewed first so I can push all of 4.6b2 out the same day to avoid broken deps. >xfconf-perl.x86_64: W: perl-temp-file >/usr/lib64/perl5/5.10.0/x86_64-linux-thread-multi/perllocal.pod >I'm not sure what to do with this file. I have on my computer in perllocal.pod >only log from modules installed in /usr/local. So probably you should remove >this file from your package. Yes, I will remove it. >xfconf-perl.x86_64: E: zero-length >/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Xfce4/Xfconf/Xfconf.bs >If it's config file, you should mark it like config. Some more digging around and it seems this is a dynloader bootstrap file. It's not needed if it's 0 length. http://www.perlmonks.org/?node_id=728926 I will remove it. >xfconf-perl.x86_64: W: hidden-file-or-dir >/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Xfce4/Xfconf/.packlist >xfconf-perl.x86_64: W: perl-temp-file >/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Xfce4/Xfconf/.packlist >You should add into spec the same line as Perl packages have: >find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \; Done. >xfconf-perl.x86_64: E: non-standard-executable-perm >/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Xfce4/Xfconf/Xfconf.so >0555 >The other perl *.so have permission 0755. ok. Changed to 0755. >xfconf-perl.x86_64: W: devel-file-in-non-devel-package >/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Xfce4/Xfconf/Install/xfconfperl-autogen.h >xfconf-perl.x86_64: W: devel-file-in-non-devel-package >/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Xfce4/Xfconf/Install/xfconfperl.h >In guidelines are no exception. You should create devel package. >perl has this exception: >https://fedoraproject.org/wiki/Packaging/Perl#.h_files_in_module_packages Thanks for spotting that Mamoru. So, I will leave these .h files and not make a devel subpackage here. new spec and src.rpm: Spec URL: http://www.scrye.com/~kevin/fedora/xfconf/xfconf.spec SRPM URL: http://www.scrye.com/~kevin/fedora/xfconf/xfconf-4.5.92-3.fc11.src.rpm Hey Marcela. Any chance to look over the comments and spec from comment #5? I found here typo in summary: %package devel Summary: Developpment tools for xfconf Everything else looks all right. ACCEPTED Thanks! Package Name: xfconf Short Description: Hierarchical configuration system for Xfce Owners: kevin Branches: devel InitialCC: cvs done. ping? Yes? I was at fudcon this weekend, and intend to import and build this sometime soon this week time permitting. I need to first build the new libxfce4util package. Sorry for any delay. Imported and built into the dist-f11-xfce tag. http://koji.fedoraproject.org/koji/taskinfo?taskID=1048289 Closing this now. Thanks for the review! |