Bug 478290
| Summary: | Review Request: screenie - A small and lightweight screen wrapper | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | manuel wolfshant <manuel.wolfshant> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | alex, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | alex:
fedora-review?
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-01-24 02:37:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Affolter
2008-12-27 10:33:44 UTC
You must add awk and screen as Requires, rpmbuild does not pick them and without them screenie bails out. sort is also a required program, but it is provided by coreutils and I guess it's safe enough to assume that coreutils is installed on any system where screenie would be used Everything else seems fine, package is too simple (it's just a shell script) to include a full review. - RPM name is OK - rpmlint is empty - license is OK (GPLv2+) - source screenie_1.30.0.orig.tar.gz is the same as upstream 1f04b055c30f5f8e4f35160bf50cfa060472a61a screenie_1.30.0.orig.tar.gz - builds fine in mock (devel/x86_64)) and being a simple shell script it's safe to assume it will work on any arch - file list is OK, even timestamps are preserved - works OK (when awk and screen are installed!) ====== Package APPROVED but please add manual requires for awk and screen ====== Thanks Manuel for the review. I will add the missing 'Requires' before cvs import. BTW, happy new year New Package CVS Request ======================= Package Name: screenie Short Description: A small and lightweight screen wrapper Owners: fab Branches: F-9 F-10 InitialCC: cvs done. screenie-1.30.0-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/screenie-1.30.0-2.fc9 screenie-1.30.0-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/screenie-1.30.0-2.fc10 screenie-1.30.0-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update screenie'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0069 screenie-1.30.0-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update screenie'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-0162 I'm switching the review flag on again, because this package should not have passed. It is causing broken deps in rawhide: http://koji.fedoraproject.org/mash/rawhide-20090108/logs/depcheck screenie-1.30.0-2.fc11.noarch requires awk This is due to a bogus "Requires: awk". There is no such package in the Fedora collection, there is only "gawk". and I'm surprised that this wasn't picked up here, it suggests that maybe an install attempt was never made. Actually it seems to be a reviewer error from comment #1, suggesting "awk" rather than "gawk". Nevertheless the packager should have verified that it installed on their local system before applying a suggested "Requires". Please fix in rawhide (and in pending bodhi requests). Thanks for pointing this out. This is my fault. The reviewer discovered the issue and I fixed it the wrong way. screenie-1.30.0-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/screenie-1.30.0-3.fc10 screenie-1.30.0-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/screenie-1.30.0-3.fc9 screenie-1.30.0-3.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update screenie'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0408 screenie-1.30.0-3.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update screenie'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-0493 screenie-1.30.0-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. screenie-1.30.0-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |