Bug 478345
Summary: | Review Request: mr - A multiple repository management tool | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
Component: | Package Review | Assignee: | Sven Lankes <sven> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | agrover, fedora-package-review, notting, sven |
Target Milestone: | --- | Flags: | sven:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-01-24 02:33:26 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Fabian Affolter
2008-12-28 14:17:44 UTC
mr help doesn't work - it tries to call man -l which doesn't exist in the current fedora man-command. It's probably easiest to just patch out the output of "use mr help for man page" I patched the '-l' parameter out. This way the users still use 'mr help' Spec URL: http://fab.fedorapeople.org/packages/SRPMS/mr.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/mr-0.35-2.fc9.src.rpm Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: f11/i386 [x] Rpmlint output: all clean [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type:GPLv2+ [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. SHA1SUM of package: f85d3b5fe50a2b2df278a143892e5d81967eb9d5 mr_0.35.tar.gz [-] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [-] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: f10/i386 [-] Package should compile and build into binary rpms on all supported architectures. Tested on: [x] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. *** APPROVED *** New Package CVS Request ======================= Package Name: mr Short Description: A multiple repository management tool Owners: fab Branches: F-9 F-10 InitialCC: cvs done. Thanks for reviewing and the cvs. mr-0.35-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/mr-0.35-2.fc10 mr-0.35-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/mr-0.35-2.fc9 I apologize for coming late in the game, but the name of the package and of the files that it installs (binary, man) violates http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Use_of_common_namespace (In reply to comment #9) > I apologize for coming late in the game, but the name of the package and of the > files that it installs (binary, man) violates > http://fedoraproject.org/wiki/PackageMaintainersPackaging_Tricks#Use_of_common_namespace Are you aware of any other tool being named "mr" or is your remark just on the two character name? mr is a pretty well established tool that fits well in the unix philosophy and thus I'd say that ignoring that 'packaging trick' is acceptable in this case - unless there are conflicts of course. No, for the moment I am not aware of any other tool with the same name, that is if we ignore http://www.dbmsmag.com/9706d07.html :) The remark was just on the two character name and the scarcity of this resource. mr-0.35-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update mr'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-0070 mr-0.35-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update mr'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0238 mr-0.35-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. mr-0.35-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: mr New Branches: el5 el6 Owners: fab Hi, wanted to get mr added to epel? Git done (by process-git-requests). |