Bug 478368
| Summary: | Review Request: linsmith - a Smith Charting program | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chitlesh GOORAH <chitlesh> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-01-07 21:49:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Chitlesh GOORAH
2008-12-29 01:22:13 UTC
33256af1c310309da6f03f2a2fe8a869 linsmith-0.99.11.tar.gz http://koji.fedoraproject.org/koji/taskinfo?taskID=1024295 1) 'desktop-file-install --vendor="fedora" \' is obsolete for new packages. Check https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor 2) install command should be %{__make} install DESTDIR=%{buildroot} INSTALL="install -p" 3)gtk-update-icon-cache scriptlet not needed as no icons installed in %{_datadir}/icons/hicolor 4) Also, I see its not needed to have update-desktop-database scriptlet. from https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database ==> Use this when a desktop entry has a 'MimeType key. Add some more description also in %description Updated: Spec URL: http://chitlesh.fedorapeople.org/RPMS/linsmith.spec SRPM URL: http://chitlesh.fedorapeople.org/RPMS/linsmith-0.99.11-2.fc10.src.rpm Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1027261 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 33256af1c310309da6f03f2a2fe8a869 linsmith-0.99.11.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Desktop files installed correctly. + GUI app. APPROVED. New Package CVS Request ======================= Package Name: linsmith Short Description: a Smith Charting program Branches: F-9 F-10 EL-5 Owner: chitlesh cvs done. linsmith-0.99.11-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/linsmith-0.99.11-2.fc9 linsmith-0.99.11-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/linsmith-0.99.11-2.fc10 linsmith-0.99.11-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. linsmith-0.99.11-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |