Bug 478506

I'll take this shortly.

Problems:

1. Name of specfile and %name don't match.
2. None of the directory names given in the comments above the Source0 line actually match the directory name used in %setup. (I see "customfieldsadminplugin" and "customfieldsadminplugin-0.10", when both should be "trac-customfieldsadminplugin-0.10".)
3. trac-webadmin-plugin (a Requires) doesn't actually exist anywhere in Fedora. Please submit that package for review and add a dependency from this ticket to that ticket. (I'll review the other one too...)
4. %{__python} setup.py build needs to go in %build.

Ping?

1) My bad, that's what I get for tired packaging and reusing an old spec
2) Fixed.
3) Fixed to be trac-webadmin
4) Fixed

Installs fine in mock now:

mock-chroot> rpm -qa | fgrep trac
trac-webadmin-0.1.2-0.3.dev_r4429.fc8.noarch
trac-0.10.5-1.fc10.noarch
trac-customfieldadmin-plugin-0.1-0.2.svn5073.fc10.noarch
mock-chroot>

Oops, should actually give locations of fixed up things :)

http://jstanley.fedorapeople.org/trac-customfieldadmin-plugin.spec
http://jstanley.fedorapeople.org/trac-customfieldadmin-plugin-0.1-0.2.svn5073.fc10.src.rpm

ping?

I'll hopefully be able to get to this tomorrow evening.

== FULL REVIEW ==

[  OK  ] specfiles match:
  fcb61fc7a2957865ab2b3e0f135eb732  trac-customfieldadmin-plugin.spec
  fcb61fc7a2957865ab2b3e0f135eb732  trac-customfieldadmin-plugin.spec.1
[FAILED] source files match upstream:
  I can't tell. The instructions included in the specfile to generate the
  tarball don't work.
  svn: '/svn/!svn/bc/5267/customfieldsadminplugin/0.10' path not found
[  OK  ] package meets naming and versioning guidelines.
[  OK  ] spec is properly named, cleanly written, and uses macros consistently.
[  OK  ] dist tag is present.
[  OK  ] build root is correct.
[  OK  ] license field matches the actual license.
[  OK  ] license is open source-compatible.
[  OK  ] license text included in package.
[  OK  ] latest version is being packaged.
[  OK  ] BuildRequires are proper.
[  N/A ] compiler flags are appropriate.
[  OK  ] %clean is present. 
[  OK  ] package builds in mock.
[  OK  ] package installs properly.
[      ] debuginfo package looks complete.
[  OK  ] rpmlint is silent.
  It did return:
   trac-customfieldadmin-plugin.noarch: W: no-documentation
   trac-customfieldadmin-plugin.noarch: E: script-without-shebang /usr/lib/python2.5/site-packages/customfieldadmin/htdocs/js/CustomFieldAdminPage_actions.js
  but seeing how it didn't come with documentation and that Javascript files 
  don't have shebangs, I'd ignore it.
[  OK  ] final provides and requires are sane
[  N/A ] %check is present and all tests pass:
[  N/A ] no shared libraries are added to the regular linker search paths.
[  OK  ] owns the directories it creates. 
[  OK  ] doesn't own any directories it shouldn't.
[  OK  ] no duplicates in %files.
[  OK  ] file permissions are appropriate.
[  N/A ] scriptlets match those on ScriptletSnippets page.
[  OK  ] code, not content.
[  OK  ] documentation is small, so no -docs subpackage is necessary.
[  OK  ] %docs are not necessary for the proper functioning of the package.
[  OK  ] no headers.
[  OK  ] no pkgconfig files.
[  OK  ] no libtool .la droppings.
[  OK  ] desktop files valid and installed properly.

 -------------------------------------------------------
  I approve this package (trac-customfieldadmin-plugin)
 -------------------------------------------------------
  (just be sure to check on the SVN instructions)

Ping -- can we close this?

Oops, forgot to do CVS on  this one :)

New Package CVS Request
=======================
Package Name: trac-customfieldadmin-plugin
Short Description: Administer custom fields from web admin interface
Owners: jstanley
Branches: F-10 F-11 EL-5
InitialCC:

CVS done.

Is this imported and ready to close yet? :)

Imported into F10 and EL-5.  Rawhide and F-11 need another version.  I'll take care of that today hopefully, but closing for now.