Bug 478534

Summary: Review Request: gnome-mastermind - Mastermind-like game for linux
Product: [Fedora] Fedora Reporter: Nicoleau Fabien <nicoleau.fabien>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED UPSTREAM QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: atorkhov, fedora-package-review, goeran, mail, musuruan, notting
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-01-08 12:14:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 182235    

Description Nicoleau Fabien 2008-12-31 16:21:32 UTC
Spec URL: http://nicoleau.fabien.free.fr/rpms/SPECS/gnome-mastermind.spec
SRPM URL: http://nicoleau.fabien.free.fr/rpms/srpms.fc10/gnome-mastermind-0.3.1-1.fc10.src.rpm
Description:
GNOME Mastermind is a little Mastermind game for linux.
The goal of this game is to break a hidden color code following the hints
that the game gives us. Check the game manual for a better explanation
about how the game works and is played. 

Rebuild under mock is OK.
SRPM builds on koji : http://koji.fedoraproject.org/koji/taskinfo?taskID=1027898
rpmlint output :
[builder@FEDOBOX ~]$ rpmlint /home/builder/rpmbuild/SRPMS/gnome-mastermind-0.3.1-1.fc10.src.rpm /home/builder/rpmbuild/RPMS/i386/gnome-mastermind-0.3.1-1.fc10.i386.rpm /home/builder/rpmbuild/RPMS/i386/gnome-mastermind-debuginfo-0.3.1-1.fc10.i386.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
[builder@FEDOBOX ~]$

Comment 1 Fabian Affolter 2009-01-01 10:09:26 UTC
Just some quick comment on your spec file

- It would be nice if you are not using a macro in URL because copy-and-paste is not possible from the spec file for humans
- Your missed to verify/install the desktop file.
  https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
- With make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" you can preserve the time stamps
- I think 'BR: GConf2-devel' is not needed

BTW, happy new year.

Comment 2 Nicoleau Fabien 2009-01-01 14:15:50 UTC
Update :
Spec URL: http://nicoleau.fabien.free.fr/rpms/SPECS/gnome-mastermind.spec
SRPM URL:
http://nicoleau.fabien.free.fr/rpms/srpms.fc10/gnome-mastermind-0.3.1-2.fc10.src.rpm

Changelog :
- Add desktop file install/validate
- Edit URL
- Preserve timestamps during install

I must preserve GConf2-devel as a BR, without this package doesn't build under mock.
rpmlint is still silent.

Happy new year too ^^

Comment 3 Andrea Musuruane 2009-01-03 13:41:41 UTC
Please read this thread:
http://lists.freedesktop.org/archives/games/2008-December/000068.html

The name of this package is a problem. Blocking FE-LEGAL.

Comment 4 Nicoleau Fabien 2009-01-08 12:14:03 UTC
I've contacted upstream.
He will change the name in a few month.
I'll open a news review after that.

Comment 5 Göran Uddeborg 2011-07-21 20:35:29 UTC
Nicoleau, what happened with this?  Was the name changed, and if so, to what?  Is there a package in Fedora today I can install to play this game?  And if so, what is it called?

Comment 6 Nicoleau Fabien 2011-07-21 21:33:24 UTC
Hi Goran,

I think that this project is inactive. During the review I proposed some new names to upstream, he told me that he will "think about it" but never replied :(

Fabien

Comment 7 Göran Uddeborg 2011-07-22 21:53:00 UTC
Ok, no point in searching for it then.  Unfortunate.

But thanks for telling!