Bug 478539

Created attachment 328018 [details]
corrected drivers file

Save to /usr/share/kde4/apps/kstars

Comment on attachment 328018 [details]
corrected drivers file

Save to /usr/share/kde4/apps/kstars

><parsererror xmlns="http://www.mozilla.org/newlayout/xml/parsererror.xml">XML Parsing Error: junk after document element
>Location: https://bugzilla.redhat.com/attachment.cgi?id=328018
>Line Number 13, Column 1:<sourcetext>&lt;devGroup group="Telescopes"&gt;
>^</sourcetext></parsererror>

Adding indiserver would be a welcome package request... I'll add it to our wishlist.  Hopefully some enterprising soul who's interested in it could step forward to help out... hint hint... :)


In the meantime, the parser error is troublesome.  Mind either providing a diff/patch and/or reporting the issue upstream to bugs.kde.org?

I'm testing kde-4.2-beta2 myself, and it would appear that devices.xml no longer exists in that version, so the point may be moot.

Doh, looks like kdeedu-4.2 no longer bundles libindi, but needs it installed separately.  Marking this to block kde42 update until done so.

pointer/reference: http://indi.sourceforge.net/

Ping? Any review request for libindi yet? Missing INDI support is a 4.2 regression, it should be fixed before 4.2.0 goes out to stable.

Actually, the stuff which used to be in kstars/indi in KDE 4.1 is now in several tarballs, which we all need for full functionality (libindi alone is just the basics):
https://sourceforge.net/project/showfiles.php?group_id=90275&package_id=94852&release_id=641238

These are what used to be included:
libindi0_0.6.tar.gz
libfli1_1.7.tar.gz
libapogee2_2.2.tar.gz
indi-apogee_1.0.tar.gz

This is already in Fedora as a separate package:
libcfitsio3_3.10.tar.gz

This one too, but an old version. The old version is sufficient, but we should still try to get it updated at least in Rawhide:
libnova0_0.12.2.tar.gz

These ones cannot be shipped in Fedora because the driver is binary only (that's the infamous sbigudrv which was always reported as missing):
indi-sbig_1.0.tar.gz
sbig_2.0.0.tar.gz
They'd have to go to RPM Fusion nonfree if somebody wants them (and presumably permission to redistribute would have to be obtained, the sbig tarball contains no license at all). sbig is the proprietary tarball, but indi-sbig (which is LGPL) does not build without it. What the copy built into KStars used to do is to build a dummy sbigudrv which only returns an error, that way you'd only have to replace the dummy library with the blob. But I don't think it makes sense to package such an indi-sbig in Fedora (we'd have to patch it or to ship an sbig-dummy package and it wouldn't be working anyway). The whole thing should go to a third-party repository if anybody cares about it at all.

So, to sum up, there should be 4 Fedora review requests (libfli, libindi (or indi or indilib, they're using all 3 variants), libapogee and indi-apogee, preferably in that order), libnova should get updated to the latest version (but we can use the one which is there for now, it's sufficient) and the sbig mess should get figured out for a third-party repository (but IMHO that one's not a blocker).

I just checked the licenses:

libfli is BSD (without the advertising clause).

libindi is mostly LGPLv2+ (v 2.1 + to be more precise), but some of the drivers are GPLv2+:
* There are some files for v4l2 conversion under libs/webcam which are GPLv2+. They should really use libv4l instead, which supports a lot more formats (and is LGPL). These are linked into the indi_lpi, indi_philips and indi_v4l drivers.
* drivers/video/stvdriver (indi_stv driver) also appears to contain GPL code (the header says so, it gives a GPLv2+ copyright notice for some copied code, the .c file doesn't, this should be clarified).
So this would be "LGPLv2+ and GPLv2+".

libapogee is GPLv2 (at least that's the version shipped with it, most of the source files contain no license headers (I've found a few files saying just "GPL", all the others say nothing), so it's unclear whether they really mean GPLv2, GPLv2+ or GPL+, clarification from upstream could be useful).

indi-apogee is LGPLv2+ (again 2.1+, but our License tags don't distinguish).

Review request for libfli

https://bugzilla.redhat.com/show_bug.cgi?id=482807

Libindi it's on the way, stay tuned :)

Ping? Any review request for libindi?

And are you also interested in the libapogee/indi-apogee stack? That adds support for INDI on some telescope hardware, it used to be included in KStars' copy of the INDI code.

(In reply to comment #10)
> Ping? Any review request for libindi?

I have a libindi package but I havn't submitted yet. 

> 
> And are you also interested in the libapogee/indi-apogee stack? That adds
> support for INDI on some telescope hardware, it used to be included in KStars'
> copy of the INDI code.

If nobody else is interested I will probably package it also.

Libindi review request:

https://bugzilla.redhat.com/show_bug.cgi?id=483438

Here is the review request for libapogee #484704

FYI, we can build KStars against libindi as soon as libindi is in, libapogee and indi-apogee can go in afterwards (it's a plugin for libindi, so it should get picked up without KStars being explicitly built against indi-apogee).

libindi support will be back in the next push.

@Sergio: I removed the libapogee review from the blockers because it's not needed to build kdeedu. But we'll want libapogee and indi-apogee reviewed and pushed out ASAP.

Also please note that we added libfli and libindi to the KDE 4.2 update, so please do NOT file separate updates for those.