Bug 478570

Summary: Review Request: oflb-riordonfancy-fonts - A stylized font
Product: [Fedora] Fedora Reporter: Ignacio Vazquez-Abrams <ivazqueznet>
Component: Package ReviewAssignee: Ignacio Vazquez-Abrams <ivazqueznet>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, fonts-bugs, notting
Target Milestone: ---Flags: nicolas.mailhot: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-02-22 18:03:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Ignacio Vazquez-Abrams 2009-01-01 05:29:08 UTC
Spec URL: http://ivazquez.fedorapeople.org/packages/RiordonFancy-fonts/RiordonFancy-fonts.spec
SRPM URL: http://ivazquez.fedorapeople.org/packages/RiordonFancy-fonts/RiordonFancy-fonts-3-1.src.rpm
Description: RiordonFancy is a highly-stylized font designed by ten-year-old Riordon Thurman. It includes all ASCII glyphs, most Latin-1 glyphs, a number of Latin Extended glyphs, and the interrobang (‽).

Comment 1 Nicolas Mailhot 2009-01-04 10:29:37 UTC
Thank you for packaging a new font.

Initial remarks:
— you should convert to the new Fedora packaging templates. That will make Behdad happy and simplify your spec file quite a bit
http://fedoraproject.org/wiki/Simple_fonts_spec_template (plain text version in fontpackages-devel)

— please use lowercase package name to keep consistency with other font packages such as dejavu-fonts

— You have more complete fontconfig templates that just need filing in fontpackages-devel (please send them upstream for inclusion in the font archive when you're happy with them)

— please ask upstream to add a detached txt license file, a readme and a fontlog. The OFL is quite specific about stuff like reserved font names, that require documentation in the license text and fontlog

— this font is available in the Open Font Library. Please ask upstream what the canonical home should be. If it is the Open Font Library, add the oflb- prefix to the fontname

— please add a page to the wiki that describes this font and will be referenced in the F11 release notes, using this template:
(see also http://fedoraproject.org/wiki/Font_package_lifecycle )

⇒ NEEDINFO while this is being taken care of

Comment 3 Nicolas Mailhot 2009-03-22 11:32:46 UTC
Nice and clean package, I don't see enough of them. Thank you for packaging a new font in Fedora!

⚸⚸⚸ APPROVED ⚸⚸⚸

You can now continue from

(Please take the time to replace your defines with globals someday btw)

Comment 4 Ignacio Vazquez-Abrams 2009-03-24 05:17:44 UTC
New Package CVS Request
Package Name: oflb-riordonfancy-fonts
Short Description: A stylized font
Owners: ivazquez
Branches: F-9 F-10

Comment 5 Kevin Fenzi 2009-03-24 17:20:21 UTC
cvs done.

Comment 6 Nicolas Mailhot 2010-02-22 18:03:29 UTC
Please do not forget to close review bug when the package has been built fedora-side