Bug 478603
| Summary: | Review Request: pysnmp - SNMP engine written in Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-02-20 11:43:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Affolter
2009-01-01 21:42:59 UTC
Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1082741 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 366c3a9f6a28851af93145c09c17e370 pysnmp-2.0.9.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. Suggestion: 1) Drop unnecessary pysnmp-examples subpackage. Same examples files already got included in main package pysnmp so its duplicate files installation at different paths. 2) License is BSD not MIT. submit new srpm with above changes. Thanks for noticing all my mistakes. First I thought that there is a benefit for making an separate -examples package but it will only save a small amount of space. Updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/pysnmp.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/pysnmp-2.0.9-2.fc9.src.rpm koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1088069 APPROVED. New Package CVS Request ======================= Package Name: pysnmp Short Description: SNMP engine written in Python Owners: fab Branches: F-9 F-10 InitialCC: cvs done. pysnmp-2.0.9-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update pysnmp'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-1202 pysnmp-2.0.9-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pysnmp'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1338 Was pushed to stable https://admin.fedoraproject.org/updates/F10/FEDORA-2009-1338 https://admin.fedoraproject.org/updates/F9/FEDORA-2009-1202 Package Change Request ====================== Package Name: pysnmp New Branches: el6 Owners: fab Git done (by process-git-requests). |