Bug 478694
| Summary: | Review Request: rfdump - RFID-Tags detector | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-01-24 02:35:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Affolter
2009-01-03 17:33:27 UTC
+ OK - Need work Review: + package builds in mock (rawhide i386). koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1032469 + rpmlint is silent for SRPM and RPM. + source files match upstream. 9db8053b5e2268234f516daed2731db8 rfdump-1.6.tar.gz - Source URL is not working and should be http://www.rfdump.org/dl/rfdump-1.6.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Package rfdump-1.6-1.fc11 => Provides: rfdump = 1.6-1.fc10 rfdump(x86-32) = 1.6-1.fc10 Requires: libatk-1.0.so.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libcairo.so.2 libexpat.so.1 libfontconfig.so.1 libfreetype.so.6 libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglade-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgtk-x11-2.0.so.0 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 libxml2.so.2 rtld(GNU_HASH) + Desktop file installed correctly. + GUI app. Suggestions: 1) Change Source URL to http://www.rfdump.org/dl/%{name}-%{version}.tar.gz APPROVED. Thanks Parag, you are right with the source url. New Package CVS Request ======================= Package Name: rfdump Short Description: RFID tags detector Owners: fab Branches: F-9 F-10 InitialCC: cvs done. rfdump-1.6-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/rfdump-1.6-2.fc9 rfdump-1.6-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/rfdump-1.6-2.fc10 rfdump-1.6-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update rfdump'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-0312 rfdump-1.6-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rfdump'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0324 rfdump-1.6-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. rfdump-1.6-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |