Bug 478841
Summary: | Tailor Mercurial repository cannot delete files after mercurial 1.1 upgrade | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Daniel Berrangé <berrange> | ||||||
Component: | tailor | Assignee: | Dan Horák <dan> | ||||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | low | ||||||||
Version: | 9 | CC: | dan | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2009-01-21 21:36:22 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Daniel Berrangé
2009-01-05 15:27:47 UTC
Created attachment 328203 [details]
Fix deleted file handling for mercurial 1.1.2 API
The syntax of the 'walk' method in mercurial.dirstate changed significantly
In 1.0.2:
- def walk(self, files=None, match=util.always, badmatch=None):
In 1.1.2:
+ def walk(self, match, unknown, ignored):
The patch I'm uploading is my best guess at what the new API wants, and allowed me to continue to convert the libvirt CVS repo to Mercurial.
It does not attempt to auto-detect which version of mercurial its running against, so it will need more work before it is suitable for tailor upstream. It would be OK for Fedora, assuming we add a 'Requires: mercurial >= 1.1.2' after applying it to RPM
tailor-0.9.35-4.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/tailor-0.9.35-4.fc9 tailor-0.9.35-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/tailor-0.9.35-4.fc10 tailor-0.9.35-4.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update tailor'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0117 tailor-0.9.35-4.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update tailor'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-0118 Created attachment 328401 [details]
reverted patch
tailor-0.9.35-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. tailor-0.9.35-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |