Bug 478877

Summary: Review Request: python-progressbar - Text progressbar library for python
Product: [Fedora] Fedora Reporter: Christof Damian <christof>
Component: Package ReviewAssignee: Mamoru TASAKA <mtasaka>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: fedora-package-review, mtasaka, notting, tuanta
Target Milestone: ---Flags: mtasaka: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: python-progressbar-2.3-4.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-01-15 08:10:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Christof Damian 2009-01-05 19:57:02 UTC
Spec URL: http://rpms.damian.net/SPECS/python-progressbar.spec
SRPM URL: http://rpms.damian.net/SRPMS/python-progressbar-2.2-1.fc10.src.rpm
Description: 
This library provides a text mode progress bar. This is typically used to 
display the progress of a long running operation, providing a visual clue that 
processing is under way.

The progressbar module is very easy to use, yet very powerful. And 
automatically supports features like auto-resizing when available.

Comment 1 Mamoru TASAKA 2009-01-06 18:17:51 UTC
Well, another simple package.

- For upstream URL, I think
  http://pypi.python.org/pypi/%{realname}/
  is enough

- For rpmlint issue:
---------------------------------------------------------
E: non-executable-script /usr/lib/python2.6/site-packages/progressbar.py 0644
---------------------------------------------------------
  If this script is not meant to be executed directory by user
  (i.e. is meant loaded by other applications, for example), usually
  this script should not have shebang.

Comment 2 Christof Damian 2009-01-06 18:43:47 UTC
(In reply to comment #1)
> Well, another simple package.

I thought I start with the small ones and the ones I use myself.

> - For upstream URL, I think
>   http://pypi.python.org/pypi/%{realname}/
>   is enough

ok.

> - For rpmlint issue:
> ---------------------------------------------------------
> E: non-executable-script /usr/lib/python2.6/site-packages/progressbar.py 0644
> ---------------------------------------------------------
>   If this script is not meant to be executed directory by user
>   (i.e. is meant loaded by other applications, for example), usually
>   this script should not have shebang.

I noticed this too, but I had a look at other packages which I have installed (for example yum) and other package reviews and this seems to be quite common.

The file contains tests, but is not executable because it is in /usr/lib/

Comment 3 Mamoru TASAKA 2009-01-08 17:45:11 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > - For rpmlint issue:
> > ---------------------------------------------------------
> > E: non-executable-script /usr/lib/python2.6/site-packages/progressbar.py 0644
> > ---------------------------------------------------------
> >   If this script is not meant to be executed directory by user
> >   (i.e. is meant loaded by other applications, for example), usually
> >   this script should not have shebang.
> 
> I noticed this too, but I had a look at other packages which I have installed
> (for example yum) and other package reviews and this seems to be quite common.
> 
> The file contains tests, but is not executable because it is in /usr/lib/

Oh, actually this script is executable (this script contains
__main__ section and actually python progressbar.py does some
program). So this script should have 0755 permission.

Comment 4 Christof Damian 2009-01-08 19:05:45 UTC
(In reply to comment #3)
> Oh, actually this script is executable (this script contains
> __main__ section and actually python progressbar.py does some
> program). So this script should have 0755 permission.

I know. This is very common and opinions on how to handle this seem to be split. 

On my system I have 73 files like this in /usr/lib/python2.5/site-packages and subdirectories and only 10 are executable. In my opinion it is best to ignore rpmlint in this case. Fixing this just makes the %files section more complicated. But I am the Fedora beginner, so I trust you.

I have updated the files:

Spec URL: http://rpms.damian.net/SPECS/python-progressbar.spec
SRPM URL: http://rpms.damian.net/SRPMS/python-progressbar-2.2-3.fc10.src.rpm

Comment 5 Mamoru TASAKA 2009-01-08 19:14:18 UTC
I think
chmod 0755 $RPM_BUILD_ROOT/%python_sitelib/progressbar.py
at %install is simpler.

Comment 6 Christof Damian 2009-01-08 19:59:05 UTC
(In reply to comment #5)
> I think
> chmod 0755 $RPM_BUILD_ROOT/%python_sitelib/progressbar.py
> at %install is simpler.

yes, much better to read too. cheers.

Spec URL: http://rpms.damian.net/SPECS/python-progressbar.spec
SRPM URL: http://rpms.damian.net/SRPMS/python-progressbar-2.2-4.fc10.src.rpm

Comment 7 Mamoru TASAKA 2009-01-09 17:36:24 UTC
For -4:

* Files
  -  In %files:

------------------------------------------------------
    49  %{python_sitelib}
------------------------------------------------------
    Well, this contains the directory %{python_sitelib} itself,
    which should not be owned by this package as this directory
    is owned by python package.

Comment 8 Christof Damian 2009-01-09 19:29:51 UTC
(In reply to comment #7)
> For -4:
> 
> * Files
>   -  In %files:
> 
> ------------------------------------------------------
>     49  %{python_sitelib}
> ------------------------------------------------------
>     Well, this contains the directory %{python_sitelib} itself,
>     which should not be owned by this package as this directory
>     is owned by python package.

Spec URL: http://rpms.damian.net/SPECS/python-progressbar.spec
SRPM URL: http://rpms.damian.net/SRPMS/python-progressbar-2.2-5.fc10.src.rpm

Comment 9 Mamoru TASAKA 2009-01-11 13:59:49 UTC
Okay.

----------------------------------------------------------------
    This package (python-progressbar) is APPROVED by mtasaka
----------------------------------------------------------------

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from "Install the Client Tools (Koji)".

Now I am sponsoring you.

If you want to import this package into Fedora 9/10, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.

Removing NEEDSPONSOR.

Comment 10 Christof Damian 2009-01-11 14:23:32 UTC
New Package CVS Request
=======================
Package Name: python-progressbar
Short Description: Text progressbar library for python
Owners: cdamian
Branches: F-10 EL-5
InitialCC:

Comment 11 Kevin Fenzi 2009-01-11 17:20:10 UTC
cvs done.

Comment 12 Mamoru TASAKA 2009-01-14 15:06:07 UTC
Please rebuild your package also on F-10 and EL-5, and
for F-10 please visit bodhi
https://admin.fedoraproject.org/updates/
and submit updates request.

Comment 13 Christof Damian 2009-01-14 21:41:11 UTC
(In reply to comment #12)
> Please rebuild your package also on F-10 and EL-5, and
> for F-10 please visit bodhi
> https://admin.fedoraproject.org/updates/
> and submit updates request.

those are now done too.

Comment 14 Mamoru TASAKA 2009-01-15 08:10:31 UTC
Okay, thanks.

Comment 15 Truong Anh Tuan 2015-01-07 16:12:36 UTC
Package Change Request
======================
Package Name: python-progressbar
New Branches: epel7
Owners: tuanta cdamian
InitialCC: tbielawa

Comment 16 Gwyn Ciesla 2015-01-07 16:25:52 UTC
Git done (by process-git-requests).

Comment 17 Fedora Update System 2015-01-08 01:00:24 UTC
python-progressbar-2.3-4.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/python-progressbar-2.3-4.el7

Comment 18 Fedora Update System 2015-01-26 20:11:37 UTC
python-progressbar-2.3-4.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.