Bug 478923

Summary: Review Request: globus-ftp-client - Globus Toolkit - GridFTP Client Library
Product: [Fedora] Fedora Reporter: Mattias Ellert <mattias.ellert>
Component: Package ReviewAssignee: Orcan Ogetbil <oget.fedora>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: fedora-package-review, notting, oget.fedora
Target Milestone: ---Flags: oget.fedora: fedora-review+
j: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 3.14-1.fc10 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-06-16 01:37:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 453847, 453848, 453851, 478920, 478922    
Bug Blocks: 478926    

Description Mattias Ellert 2009-01-06 01:08:15 UTC
Spec URL: http://www.grid.tsl.uu.se/repos/globus/info/globus-ftp-client.spec
SRPM URL: http://www.grid.tsl.uu.se/repos/globus/fedora/10/src/SRPMS/globus-ftp-client-3.14-0.3.fc10.src.rpm

Description:
The Globus Toolkit is an open source software toolkit used for
building Grid systems and applications. It is being developed by the
Globus Alliance and many others all over the world. A growing number
of projects and companies are using the Globus Toolkit to unlock the
potential of grids for their cause.

The globus-ftp-client package contains:
GridFTP Client Library

BuildRequires:	grid-packaging-tools
BuildRequires:	globus-xio-popen-driver-devel
BuildRequires:	globus-common-devel >= 4
BuildRequires:	globus-ftp-control-devel >= 1
BuildRequires:	globus-core-devel >= 4

Based on the globus toolkit 4.2.1 release.

Applied patches submitted upstream:

Remove some doxygen warnings:
http://bugzilla.globus.org/bugzilla/show_bug.cgi?id=6600

Dereferencing of type-punned pointers:
http://bugzilla.globus.org/bugzilla/show_bug.cgi?id=6602

Comment 1 Mattias Ellert 2009-03-16 00:02:05 UTC
New version
- Added s390x as 64 bit arch
- Added comment documenting source
- Adapt to changes in the globus-core package

http://www.grid.tsl.uu.se/repos/globus/fedora/10/src/SRPMS/globus-ftp-client-3.14-0.5.fc10.src.rpm
http://www.grid.tsl.uu.se/repos/globus/info/globus-ftp-client.spec

Comment 2 Mattias Ellert 2009-04-17 13:45:10 UTC
Package updated due to new packaging guidelines
- Change defines to globals
- Remove explicit requires on library packages

http://www.grid.tsl.uu.se/repos/globus/info/new/globus-ftp-client-3.14-1.fc10.src.rpm
http://www.grid.tsl.uu.se/repos/globus/info/new/globus-ftp-client.spec

Draft packaging guidelines for Globus packages are now available:
http://fedoraproject.org/wiki/PackagingDrafts/Globus

Comment 3 Orcan Ogetbil 2009-06-03 05:09:18 UTC
There is a tiny issue. Otherwise the package is fine

- rpmlint
   globus-ftp-client-devel.x86_64: W: no-documentation
can be ignored

- koji rawhide build is fine:
   http://koji.fedoraproject.org/koji/taskinfo?taskID=1390424

* Please fix this warning
   globus_ftp_client_restart_marker.c:710: warning: format '%n' expects type 'int *', but argument 5 has type 'globus_size_t *'


----------------------------------------------------
This package (globus-ftp-client) is APPROVED by oget
----------------------------------------------------

Comment 4 Mattias Ellert 2009-06-03 07:40:25 UTC
Thank you for the review - I'll fix the warning...

New Package CVS Request
=======================
Package Name: globus-ftp-client
Short Description: Globus Toolkit - GridFTP Client Library
Owners: ellert
Branches: F-9 F-10 F-11 EL-4 EL-5
InitialCC:

Comment 5 Jason Tibbitts 2009-06-03 16:54:39 UTC
CVS done.

Comment 6 Fedora Update System 2009-06-04 04:35:14 UTC
globus-ftp-client-3.14-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/globus-ftp-client-3.14-1.fc10

Comment 7 Fedora Update System 2009-06-04 04:35:20 UTC
globus-ftp-client-3.14-1.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/globus-ftp-client-3.14-1.fc9

Comment 8 Fedora Update System 2009-06-04 04:35:25 UTC
globus-ftp-client-3.14-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/globus-ftp-client-3.14-1.fc11

Comment 9 Fedora Update System 2009-06-16 01:37:40 UTC
globus-ftp-client-3.14-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2009-06-16 01:46:16 UTC
globus-ftp-client-3.14-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2009-06-16 02:07:23 UTC
globus-ftp-client-3.14-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.