Bug 478930
| Summary: | Review Request: globus-rls-client - Globus Toolkit - Replica Location Service Client | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mattias Ellert <mattias.ellert> |
| Component: | Package Review | Assignee: | Orcan Ogetbil <oget.fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, oget.fedora |
| Target Milestone: | --- | Flags: | oget.fedora:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 5.1-2.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-06-04 21:12:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 453847, 453848, 453851, 467237, 478921 | ||
| Bug Blocks: | 478931 | ||
|
Description
Mattias Ellert
2009-01-06 01:19:18 UTC
New version - Added s390x as 64 bit arch - Added comment documenting source - Adapt to changes in the globus-core package http://www.grid.tsl.uu.se/repos/globus/fedora/10/src/SRPMS/globus-rls-client-5.1-0.5.fc10.src.rpm http://www.grid.tsl.uu.se/repos/globus/info/globus-rls-client.spec Package updated due to new packaging guidelines - Change defines to globals - Remove explicit requires on library packages http://www.grid.tsl.uu.se/repos/globus/info/new/globus-rls-client-5.1-1.fc10.src.rpm http://www.grid.tsl.uu.se/repos/globus/info/new/globus-rls-client.spec Draft packaging guidelines for Globus packages are now available: http://fedoraproject.org/wiki/PackagingDrafts/Globus There are some issues with this one: - koji rawhide build seems fine http://koji.fedoraproject.org/koji/taskinfo?taskID=1385823 ! The file CHANGELOG can go to a %doc * The source extraction guide is incomplete. The original source tree contains a ./java directory, which is missing from your tarball. Is there a reason? ? There is some html documentation under the ./Doc directory. Currently there is a doxygen documentation in the doc package which seemed to me rather useless. Shall we replace it with the html documentation from the ./Doc directory? - rpmlint globus-rls-client-devel.x86_64: W: no-documentation can be ignored. (Well, the CHANGELOG might fit in here) * Please fix the compilation warnings of the type rpc.c:395: warning: format '%d' expects type 'int', but argument 3 has type 'globus_size_t' (In reply to comment #3) > ! The file CHANGELOG can go to a %doc The CHANGELOG file's last entry is for version 2.1.3, the current version is 5.1. Since the CHANGELOG file is not maintained it doesn't make much sense to include it. > * The source extraction guide is incomplete. The original source tree contains > a ./java directory, which is missing from your tarball. Is there a reason? Yes, the java directory is not part of the globus-rls-client source package, but a separate source package of its own. The build GPT build instructions in the pkgdata directory does not contain information about how to build the java package. The java directory contains its own pkgdata directory with build instructions for the java package. I have added a line to the source extraction guide that removes the java directory before packaging the source tarball. > ? There is some html documentation under the ./Doc directory. Currently there > is a doxygen documentation in the doc package which seemed to me rather > useless. Shall we replace it with the html documentation from the ./Doc > directory? The bug is in the LAC_DOXYGEN call in configure.in - it points to the main directory instead of the library subdirectory. Fixed. > * Please fix the compilation warnings of the type > rpc.c:395: warning: format '%d' expects type 'int', but argument 3 has type > 'globus_size_t' Fixed. http://www.grid.tsl.uu.se/repos/globus/info/new/globus-rls-client-5.1-2.fc10.src.rpm http://www.grid.tsl.uu.se/repos/globus/info/new/globus-rls-client.spec Thanks! ---------------------------------------------------- This package (globus-rls-client) is APPROVED by oget ---------------------------------------------------- Thank you for the review. New Package CVS Request ======================= Package Name: globus-rls-client Short Description: Globus Toolkit - Replica Location Service Client Owners: ellert Branches: F-9 F-10 F-11 EL-4 EL-5 InitialCC: CVS done. globus-rls-client-5.1-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/globus-rls-client-5.1-2.fc10 globus-rls-client-5.1-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/globus-rls-client-5.1-2.fc9 globus-rls-client-5.1-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/globus-rls-client-5.1-2.fc11 globus-rls-client-5.1-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. globus-rls-client-5.1-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. globus-rls-client-5.1-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |