Bug 479008
Summary: | Review Request: libQGLViewer - Qt based OpenGL generic 3D viewer library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Laurent Rineau <laurent.rineau__fedora> |
Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, lkundrak, notting, rdieter |
Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 2.3.1-8.fc10 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-04-02 17:12:30 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Laurent Rineau
2009-01-06 13:50:35 UTC
(In reply to comment #0) > - As a matter of fact, while writing the current review request, I have > discovered that there may be a license issue: libQGLViewer ships and is > combined with the VRender library, which is under GPLv2+ only (not exceptions). > That probably cancel the exceptions. The upstream developer of VRender is a > college of Gilles Debunne. I will ask them if the exception can be added to > VRender as well. Until then, libQGLViewer could be declared as "License: GPLv2 > or GPLv3". Cyril Soler, the upstream developer of VRender, agrees to add the same license exceptions to VRender. That should be done soon. Let us say that this will be done before the end of this review. One possible simplification would be to check to see if the -devel subpkg needs qt4-devel or not (qt4 headers), and if so, include the desiginer plugin in -devel (one less subpkg). Hi Rex, I do not know why I made a separate sub-package. Most probably I remember the time when Qt4 designer was in its own sub-package (in 2006). To answer your question, the -devel sub-package does need qt4-devel. And I forgot that Requires! :-S Update: Spec URL: http://www.normalesup.org/~rineau/Fedora/libQGLViewer.spec SRPM URL: http://www.normalesup.org/~rineau/Fedora/libQGLViewer-2.3.1-6.fc10.src.rpm Changelog: * Tue Jan 6 2009 Laurent Rineau <Laurent.Rineau__fedora> - 2.3.1-6 - Merge the subpackage -designer-plugin into -devel. - Add Requires: qt4-devel to -devel. Note: Because of the merge, I could have add an Obsoletes: in -devel (Provides is useless as nothing currently depends on libQGLViewer-designer-plugin), but I have commented it: as the package is not yet in Fedora collection, that Obsoletes: is an overkill. 1.) No useless comments please #Obsoletes: %{name}-designer-plugin < %{version}-%{release} 2.) This is useless, even gcc itself grabs this in: BuildRequires: glibc-common * Source file matches upstream * SPEC file is clean and legible * Builds fine in mock (http://koji.fedoraproject.org/koji/taskinfo?taskID=1258482) * File list looks sane * Requires/Provides are sane * Headers and libraries files in -devel * Compile flags used properly * Checked for functionality (built and run skyviewer) APPROVED Laurent: ping. Please request CVS for this. I have never received the email corresponding to comment #4. Thank you for the ping, Lubomir (and for the review). (In reply to comment #4) > 1.) No useless comments please > > #Obsoletes: %{name}-designer-plugin < %{version}-%{release} Right. > 2.) This is useless, even gcc itself grabs this in: > > BuildRequires: glibc-common :-) That is silly, actually. I have added `rpm -qf /usr/bin/iconv` without remarking that it was a quite common package! I will remove those two lines just after the cvs import. New Package CVS Request ======================= Package Name: libQGLViewer Short Description: Qt based OpenGL generic 3D viewer library Owners: rineau Branches: F-10 InitialCC: cvs done. libQGLViewer-2.3.1-7.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/libQGLViewer-2.3.1-7.fc10 libQGLViewer-2.3.1-7.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/libQGLViewer-2.3.1-7.fc10 (In reply to comment #10) I had revoked my request for the update to F-10, to avoid an upgrade-path problems between F-10+updates to F-11-without-updates. And I just noticed that the beta-freeze policy allows new packages builds. So I have re-requested the update. libQGLViewer-2.3.1-7.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. libQGLViewer-2.3.1-8.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/libQGLViewer-2.3.1-8.fc10 libQGLViewer-2.3.1-8.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: libQGLViewer New Branches: EL-5 EL-6 Owners: rineau The Fedora Astronomy SIG asks for libQGLViewer to be in EL-6 (at least one of their packages need it). I have a EL-5-enabled machine (under CentOS), and somebody from the Astronomy SIG will co-maintain the EL-6 branch once it is created. CVS done (by process-cvs-requests.py). |