Bug 479252
| Summary: | [RHEL5] ipmitool doesn't accept hex codes for k_g | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Tomas Smetana <tsmetana> | ||||
| Component: | OpenIPMI | Assignee: | Jan Safranek <jsafrane> | ||||
| Status: | CLOSED ERRATA | QA Contact: | BaseOS QE <qe-baseos-auto> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 5.3 | CC: | cward, rvokal, tao | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-09-02 09:59:51 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Tomas Smetana
2009-01-08 12:51:29 UTC
Created attachment 328460 [details]
Proposed patch
Here's the code stolen from freeipmi which should allow the user to enter the k_g key as a hex value.
I'd rather add new parameter, say '-K', which accepts only hexa-codes as key. What if an user has key starting with "0x"? The attached patch would do something what the user doesn't expect. Is there any customer request to mimic FreeIPMI behaviour? (In reply to comment #2) > I'd rather add new parameter, say '-K', which accepts only hexa-codes as key. > What if an user has key starting with "0x"? The attached patch would do > something what the user doesn't expect. Is there any customer request to mimic > FreeIPMI behaviour? I think the user would be OK with any option that would allow him to enter the hexa values (but "-K" is taken already). And yes, I believe he would be OK even if we just mimicked the FreeIPMI... The patch is just a suggestion. Patch sent upstream: https://sourceforge.net/mailarchive/forum.php?thread_name=496DF4A1.5010507%40redhat.com&forum_name=ipmitool-devel I had to rewrite the hex parsing, stealing from GPL FreeIPMI is not a good idea. The patch was accepted upstream. Fixed by rebase to ipmitool-1.8.11 ~~ Attention - RHEL 5.4 Beta Released! ~~ RHEL 5.4 Beta has been released! There should be a fix present in the Beta release that addresses this particular request. Please test and report back results here, at your earliest convenience. RHEL 5.4 General Availability release is just around the corner! If you encounter any issues while testing Beta, please describe the issues you have encountered and set the bug into NEED_INFO. If you encounter new issues, please clone this bug to open a new issue and request it be reviewed for inclusion in RHEL 5.4 or a later update, if it is not of urgent severity. Please do not flip the bug status to VERIFIED. Only post your verification results, and if available, update Verified field with the appropriate value. Questions can be posted to this bug or your customer or partner representative. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHEA-2009-1312.html |