Bug 479595
| Summary: | Review Request: raddump - RADIUS packets interpreter | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Adel Gadllah <adel.gadllah> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | adel.gadllah, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | adel.gadllah:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-02-20 11:40:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Affolter
2009-01-11 21:45:11 UTC
REVIEW: [+] = OK [-] = NOT OK [1] = SEE COMMENTS [?] = WTF? =========================== [+] source files match upstream: sha1: 13b75ec8ad1f4fcbed7ebe7373718ec254429e72 [+] package meets naming and versioning guidelines. [+] specfile is properly named, is cleanly written and uses macros consistently. [+] dist tag is present. [+] build root is correct. [+] license field matches the actual license. [+] license is open source-compatible. GPLv2+ [+] license text included in package. [+] latest version is being packaged. [+] BuildRequires are proper. [+] compiler flags are appropriate. [+] %clean is present. [+] package builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1079868 [+] package installs properly. [+] debuginfo package looks complete. [+] rpmlint is silent. [+] final provides and requires are sane [+] no shared libraries are added to the regular linker search paths. [+] owns the directories it creates. [+] doesn't own any directories it shouldn't. [+] no duplicates in %files. [+] file permissions are appropriate. [+] no scriptlets present. [+] code, not content. [+] documentation is small, so no -docs subpackage is necessary. [+] %docs are not necessary for the proper functioning of the package. [+] no headers. [+] no pkgconfig files. [+] no libtool .la droppings. =========================== COMMENTS: None, package looks good, no issues found. => APPROVED New Package CVS Request ======================= Package Name: raddump Short Description: RADIUS packets interpreter Owners: fab Branches: F-9 F-10 InitialCC: cvs done. Thanks for reviewing and the cvs. raddump-0.3.1-1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update raddump'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-0951 raddump-0.3.1-1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update raddump'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0982 |