Bug 479666
| Summary: | Review Request: perl-Parse-ErrorString-Perl - perl-Parse-ErrorString-Perl | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marcela Mašláňová <mmaslano> | ||||
| Component: | Package Review | Assignee: | Ralf Corsepius <rc040203> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review, notting, rc040203 | ||||
| Target Milestone: | --- | Flags: | rc040203:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-01-14 07:52:30 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Marcela Mašláňová
2009-01-12 12:16:45 UTC
MUSTFIX: - Missing BR: to pull in dos2unix I recommend to use /usr/bin/dos2unix and using BR: /usr/bin/dos2unix CONSIDER: - CRLF conversion should be performed on sources, not on installed files. Created attachment 328838 [details] Proposed spec changes to address issues from comment #1 Thank you for your review. http://mmaslano.fedorapeople.org/perl-Parse-ErrorString-Perl/perl-Parse-ErrorString-Perl-0.11-2.fc10.src.rpm http://mmaslano.fedorapeople.org/perl-Parse-ErrorString-Perl/perl-Parse-ErrorString-Perl.spec There is a redundant "Requires: perl(Pod::POM)" in your spec. APPROVED, provided you remove this. I'll remove it before push to repo. New Package CVS Request ======================= Package Name: perl-Parse-ErrorString-Perl Short Description: Parse error messages from the perl interpreter Owners: mmaslano Branches: F-10 devel InitialCC: perl-sig cvs done. |