Bug 479723
| Summary: | Review Request: cgit - A fast webinterface for git | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Todd Zullinger <tmz> |
| Component: | Package Review | Assignee: | seth vidal <svidal> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, tcallawa |
| Target Milestone: | --- | Flags: | svidal:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.8.2-1.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-02-24 20:41:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Todd Zullinger
2009-01-12 18:01:40 UTC
rpmlint checks out package passes all MUST requirements from review checks Does it REALLY require httpd - or does it only require 'webserver'? httpd is required for ownership of /etc/httpd/conf.d. If that can be made more generic, I'd be all for it. The other comment I have from a quick look is that the %define at the top for the make really probably should just be explicitly in the %build section. From Tibbs:
The package shouldn't own this dir:
%define scriptdir %{_localstatedir}/www/cgi-bin
End from Tibbs.
From Me:
that is provided by httpd which the pkg already deps on, so it's okay to remove that dir ownership.
If you remove the ownership of that dir then this pkg is approved.
(In reply to comment #3) > The other comment I have from a quick look is that the %define at the top for > the make really probably should just be explicitly in the %build section. True, it could be. I had it there to start, but it causes a spurious warning from rpmlint, which I figured could be easily avoided by defining it outside of %build and %prep. Does that cause any harm? And is it uglier there than the rpmlint warning might be? Thanks for the quick review Seth (and the helpful eyes from Tibbs). I'll fix that ownership up thusly:
-%{scriptdir}
+%{scriptdir}/*
Any concerns about getting the SELinux contexts setup properly before importing the package? I could add some policy to the package, but I couldn't find any guidelines on whether that was preferable to getting the changes into selinux-policy directly. All I found was a draft, which might be old and outdated:
http://fedoraproject.org/wiki/PackagingDrafts/SELinux
New Package CVS Request ======================= Package Name: cgit Short Description: A fast webinterface for git Owners: tmz Branches: F-10 F-9 EL-5 InitialCC: cvs done. cgit-0.8.2-1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update cgit'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-1447 cgit-0.8.2-1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update cgit'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1473 cgit-0.8.2-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. cgit-0.8.2-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |