Bug 479750 (libcelt)
| Summary: | Review Request: libcelt - low-latency compressed audio format for voice and music | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Monty <cmontgom> |
| Component: | Package Review | Assignee: | Ray Strode [halfline] <rstrode> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, kem, lemenkov, notting, pbrobinson, rstrode |
| Target Milestone: | --- | Flags: | rstrode:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-01-13 17:54:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 478941 | ||
| Bug Blocks: | |||
|
Description
Monty
2009-01-12 21:14:38 UTC
The only real issue i see is that you need to
Requires: pkg-config
since you ship .pc files
Other than that, rpmlint gave a few warnings that you may want to fix up:
1) you run make check in %build but normally you'd run that in %check
2) you mix tabs and spaces
3) the tarball in the srpm is 0600 instead of 0644 or whatever
4) You're changelog entry doesn't have a version at the end of it.
Normally you'd do something like:
* Mon Dec 22 2008 Monty Montgomery <monty> 0.5.1-0
- Initial spec file
Last thing I'd bring up is you have an
Epoch: 0
and
Requires: libcelt = %{epoch}:%{version}-%{release}
but often epochs aren't explicitly given unless they're non-zero.
Anyway, the only change you really need afaict is the Requires for pkg-config
>The only real issue i see is that you need to >Requires: pkg-config >since you ship .pc files Fixed >1) you run make check in %build but normally you'd run that in %check Changed >2) you mix tabs and spaces Emacs is doing that mainly because the .emacs file config to make it stop seems to change every minor release and I'm sick of fixing it every time I update. >3) the tarball in the srpm is 0600 instead of 0644 or whatever Changed 4) You're changelog entry doesn't have a version at the end of it. Fixed I've refreshed the files at http://people.xiph.org/~xiphmont/CELT with the above changes. looks good. New Package CVS Request ======================= Package Name: libcelt Short Description: The CELT Low-Latency Audio Compression Codec Owners: xiphmont Branches: F-10 InitialCC: Please look at the package review queue befora submitting review https://bugzilla.redhat.com/show_bug.cgi?id=478941 This is the same as my package review. And the package is not labelled according the the fedora policy. Hi Peter, Monty explained why the name is "libcelt" instead of "celt" in his initial comment. Do you guys mind being comaintainers with each other? I'm happy to do it any which way. I'm part of the upstream team, so it makes sense especially as the codebase is brand new. Alright, let's close this report out since the other one was filed first. *** This bug has been marked as a duplicate of bug 478941 *** I'm happy with co-maintainer, I initially packaged it so I could add support to ekiga. Will update the other bug report. |