Bug 479846
Summary: | git repo version is still setting fstype too late | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Bruno Wolff III <bruno> |
Component: | livecd-tools | Assignee: | Jeremy Katz <katzj> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | apevec, davidz, dhuff, katzj |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-04-13 15:09:21 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Bruno Wolff III
2009-01-13 15:36:30 UTC
I did try taking out the rootfstype stuff to see if it was necessary and the boot did end up failing with a mount not able to recognize the type. So it does appear some guidance is necessary. It's kind of odd since I can mount the iso without specifying a type normally. The boot process also starts normally, so the bios sees things OK. And the the initial kernel appears to load OK. Okay, went a step further and made rootfstype=auto do the right thing in the initrd and switched to using that. This may mean that we don't entirely act nicely for > 4GB images with older distros, but I think the only thing that really would have gotten lost would be the checkisomd5 bits. And those were getting dropped for udf as well as auto FYI. The spins SIG decided in today's meeting that the alpha games spin iso should be under 4 GiB. This will be reevaluated at the beta. So there is less hurry to do this patch. I'll continue to test it with a private kickstart file, but for tonight I'll be updating a pruned down live games spin kickstart. http://git.fedorahosted.org/git/?p=livecd;a=commit;h=616642a5d56b8e453614f7a8845a61b033c9ac4f this broke media check, it is never performed, even with check bootparameter. livecd initrd has this condition: if [ "x$check_iso" == "x1" -a -x /bin/checkisomd5 -a "x$rootfstype" == "xiso9660" ]; then ... Could initrd be made smarter when checking filesystem type, instead of relying on bootparameter value? (In reply to comment #4) > Could initrd be made smarter when checking filesystem type, instead of relying > on bootparameter value? That was done at the same time :-) See 24d6d9779ca5bacc0c649e9d783263661ceb81f0 of mkinitrd This has been fixed for a while now. |