Bug 479866

Summary: Review Request: eclipse-linuxprofilingframework - Eclipse Linux Tools Profiling Framework
Product: [Fedora] Fedora Reporter: Andrew Overholt <overholt>
Component: Package ReviewAssignee: Alexander Kurtakov <akurtako>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: akurtako, fedora-package-review, notting
Target Milestone: ---Flags: akurtako: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-01-26 20:00:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Andrew Overholt 2009-01-13 17:27:06 UTC
Spec URL: http://overholt.fedorapeople.org/eclipse-linuxprofilingframework.spec
SRPM URL: http://overholt.fedorapeople.org/eclipse-linuxprofilingframework-0.1.0-0.1.fc10.src.rpm
Description: Plugins common to Eclipse Linux Tools profiling tools.

Comment 1 Alexander Kurtakov 2009-01-22 21:33:05 UTC
Taking this one.

Comment 2 Alexander Kurtakov 2009-01-22 21:34:34 UTC
OK rpmlint shows no warnings
OK package named correctly
OK spec file named correctly
OK meets the Packaging Guidelines .
OK license is correct, approved and in the %doc
OK The License field in the package spec file must match the actual license.
OK Shell script for fetching sources is included
OK The package MUST successfully compile and build into binary rpms on at least one primary architecture. 
OK owns all directories
OK doesn't contain any duplicate files
OK permissions are correctly set
OK clean section present
OK Each package must consistently use macros. 
OK The package must contain code, or permissable content. 
OK  no large documentation files 
OK If a package includes something as %doc, it must not affect the runtime of the application. 
OK  Packages must not own files or directories already owned by other packages. T
OK At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). 
OK All filenames in rpm packages must be valid UTF-8

The package is good to go.

Comment 3 Andrew Overholt 2009-01-23 17:07:11 UTC
Thanks for the review, Alex!

Comment 4 Andrew Overholt 2009-01-23 17:14:11 UTC
New Package CVS Request
=======================
Package Name: eclipse-linuxprofilingframework
Short Description: Plugins common to Eclipse Linux Tools profiling tools.
Owners: overholt
Branches: F-10
InitialCC: ebaron

Comment 5 Kevin Fenzi 2009-01-23 23:08:33 UTC
cvs done.

Comment 6 Andrew Overholt 2009-01-26 20:00:22 UTC
This is now built in rawhide.